-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Replace 25% & 50% width inline styles with respective classes #28692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What is the benefit of replacing style width with classes? |
To address CSP. See #27297. |
@Quy I think on your description you meant „... no need to create these classes“, but the “no” is missing. |
Fixed. Thanks. |
I have tested this item ✅ successfully on 9fa541f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28692. |
1 similar comment
I have tested this item ✅ successfully on 9fa541f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28692. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28692. |
Thanks |
joomla-cms-bot
added
PR-4.0-dev
and removed
RTC
This Pull Request is Ready To Commit
labels
Apr 17, 2020
This was referenced May 2, 2020
This was referenced May 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #27344 to fix conflicts and do incremental PRs for easy testing.
Thanks @chang-zhao for the initial PR.
Summary of Changes
Replace width inline styles with classes.
w-25
andw-50
are Bootstrap sizing classes so no need to create these classes.Testing Instructions
Code review.
or
Log in to administration.
No visual changes in the following:
See
Logged-in Users
module.See System > System Information > System Information tab