Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Replace 25% & 50% width inline styles with respective classes #28692

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

Quy
Copy link
Contributor

@Quy Quy commented Apr 15, 2020

Redo of #27344 to fix conflicts and do incremental PRs for easy testing.

Thanks @chang-zhao for the initial PR.

Summary of Changes

Replace width inline styles with classes.

w-25 and w-50 are Bootstrap sizing classes so no need to create these classes.

Testing Instructions

Code review.
or
Log in to administration.
No visual changes in the following:
See Logged-in Users module.
See System > System Information > System Information tab

@ciar4n
Copy link
Contributor

ciar4n commented Apr 15, 2020

What is the benefit of replacing style width with classes?

@Quy
Copy link
Contributor Author

Quy commented Apr 15, 2020

To address CSP. See #27297.

@richard67
Copy link
Member

@Quy I think on your description you meant „... no need to create these classes“, but the “no” is missing.

@Quy
Copy link
Contributor Author

Quy commented Apr 15, 2020

Fixed. Thanks.

@jwaisner
Copy link
Member

I have tested this item ✅ successfully on 9fa541f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28692.

1 similar comment
@ChristineWk
Copy link

I have tested this item ✅ successfully on 9fa541f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28692.

@Quy
Copy link
Contributor Author

Quy commented Apr 16, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28692.

@Quy Quy removed the PR-4.0-dev label Apr 16, 2020
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 16, 2020
@HLeithner HLeithner merged commit 423272f into joomla:4.0-dev Apr 17, 2020
@HLeithner
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants