Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix PHP error with pagebreak #28797

Merged
merged 1 commit into from Apr 25, 2020
Merged

[4.0] Fix PHP error with pagebreak #28797

merged 1 commit into from Apr 25, 2020

Conversation

C-Lodder
Copy link
Member

Pull Request for Issue #28795

Summary of Changes

Fix a PHP error being throw with the pagebreak plugin

Testing Instructions

  1. Add a page break to any article
  2. View the article in the frontend

Expected result

The article is displayed

Actual result

PHP error

@alikon
Copy link
Contributor

alikon commented Apr 25, 2020

I have tested this item ✅ successfully on 3a1f061


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28797.

@faustonenci
Copy link

I have tested this item ✅ successfully on 3a1f061

good


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28797.

@alikon
Copy link
Contributor

alikon commented Apr 25, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28797.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 25, 2020
@adj9
Copy link

adj9 commented Apr 25, 2020

I have tested this item ✅ successfully on 3a1f061

I confirm what happens in the frontEnd with an article that has the page break.
click on bleak and Articol index is moved
Schermata 2020-04-25 alle 17 57 05

Without patch there is the error
The requested page can't be found.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28797.

@richard67
Copy link
Member

Thanks all.

@richard67 richard67 merged commit ddd9dd0 into joomla:4.0-dev Apr 25, 2020
@joomla-cms-bot joomla-cms-bot added PR-4.0-dev and removed RTC This Pull Request is Ready To Commit labels Apr 25, 2020
@richard67 richard67 added this to the Joomla 4.0 milestone Apr 25, 2020
@C-Lodder C-Lodder deleted the patch-1 branch April 25, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants