Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix js error when previewing admin template #29124

Merged

Conversation

infograf768
Copy link
Member

Pull Request for Issue #29120

Summary of Changes

Use conditional for the $content variable

Testing Instructions

Make sure that the Preview Module Positions is set to enabled
Click on the eye to open the preview if in template style or Preview Toolbar in templates manager

Before patch

js error. See #29120

After patch

No more error

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels May 17, 2020
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 673f18a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29124.

1 similar comment
@richard67
Copy link
Member

I have tested this item ✅ successfully on 673f18a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29124.

@richard67 richard67 removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels May 17, 2020
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29124.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 17, 2020
@richard67 richard67 added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels May 17, 2020
@Quy Quy added this to the Joomla 4.0 milestone May 17, 2020
@wilsonge wilsonge merged commit 5040c41 into joomla:4.0-dev May 17, 2020
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 17, 2020
@infograf768 infograf768 deleted the 4.0_admintemplate_preview_js_error branch May 18, 2020 05:29
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants