Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging] Missing Web Links language strings #30253

Merged
merged 2 commits into from
Aug 2, 2020

Conversation

infograf768
Copy link
Member

Summary of Changes

As title says. This PR adds strings present in last version (3.7.0) of web links.
Installing the web links package will provide the new strings but these are not present in the other languages pack as they are absent from en-GB core distribution.
Using German in backend will show the strings have not been added/translated.

Testing Instructions

Install weblinks package. https://downloads.joomla.org/extensions/weblinks/3-7-0

Switch backend to German.
Set Debug Language on

Create a weblink.

Actual result BEFORE applying this Pull Request

Example:
Screen Shot 2020-08-01 at 11 32 31

Expected result AFTER applying this Pull Request

As the strings will now be present (after translation by German Team in next release), they will show Ok.
The French pack does already contain these missing strings

Screen Shot 2020-08-01 at 11 37 45

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Aug 1, 2020
@chmst
Copy link
Contributor

chmst commented Aug 1, 2020

I have tested this item ✅ successfully on e880cd0

By chance I am working on a site with the weblinks component right now - so could test at once.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30253.

@infograf768
Copy link
Member Author

infograf768 commented Aug 2, 2020

@chmst
We also miss 4 ini files. Grrr

plg_editors-xtd_weblink.ini
plg_editors-xtd_weblink
plg_system_weblinks.ini
plg_system_weblinks.sys.ini

Shall I add them here or in new patch? What you think?

@universewrld
Copy link

@infograf768 I was creating 2 issues (418 & 419) that are currently in this component, but no one answered. is this component currently being developed here or in another directory?

@chmst
Copy link
Contributor

chmst commented Aug 2, 2020

Add it to this PR. It is an easy test

@infograf768
Copy link
Member Author

@sanek4life
Any issue with weblinks is indeed to be created where you did it. Needs a volunteer to correct bugs there. Will have a look.

@infograf768
Copy link
Member Author

@chmst
Done.

@chmst
Copy link
Contributor

chmst commented Aug 2, 2020

I have tested this item ✅ successfully on c5aa50a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30253.

@infograf768
Copy link
Member Author

@HLeithner
Please merge.

@infograf768
Copy link
Member Author

@sanek4life
Replied to both your issues (418 & 419) for weblinks.

@HLeithner HLeithner merged commit 0b08fb9 into joomla:staging Aug 2, 2020
@HLeithner
Copy link
Member

Thanks, I'm wondering why com_weblinks translations are still in core...

@zero-24 zero-24 added this to the Joomla! 3.9.21 milestone Aug 3, 2020
@infograf768 infograf768 deleted the weblinks_missing_strings branch August 3, 2020 06:02
@infograf768
Copy link
Member Author

infograf768 commented Aug 3, 2020

Thanks, I'm wondering why com_weblinks translations are still in core...

It was decided to keep the web links ini files in core for the 3x series when web links were separated as we have no structure to propose specific languages for them.

@HLeithner
Copy link
Member

thx for the info

@Bakual
Copy link
Contributor

Bakual commented Aug 3, 2020

More background to language files in weblinks: joomla-extensions/weblinks#383

@infograf768
Copy link
Member Author

At this stage, all web links ini files are no more present in J4.

See joomla-extensions/weblinks#415 (comment)

infograf768 added a commit to infograf768/joomla-cms that referenced this pull request Aug 4, 2020
HLeithner pushed a commit that referenced this pull request Aug 4, 2020
Kostelano added a commit to JPathRu/localisation that referenced this pull request Aug 21, 2020
Новые константы, вышла 3.9.21 RC
joomla/joomla-cms#30221
joomla/joomla-cms#30390 (не вносил изменения, у нас "Менеджер" есть и в других местах)
joomla/joomla-cms#30157
joomla/joomla-cms#30110
joomla/joomla-cms#29895
joomla/joomla-cms#30253
Reconix pushed a commit to Reconix/joomla-cms that referenced this pull request Aug 31, 2020
Reconix pushed a commit to Reconix/joomla-cms that referenced this pull request Aug 31, 2020
Reconix added a commit to Reconix/joomla-cms that referenced this pull request Aug 31, 2020
Reconix added a commit to Reconix/joomla-cms that referenced this pull request Aug 31, 2020
Reconix added a commit to Reconix/joomla-cms that referenced this pull request Aug 31, 2020
Reconix added a commit to Reconix/joomla-cms that referenced this pull request Aug 31, 2020
Reconix added a commit to Reconix/joomla-cms that referenced this pull request Aug 31, 2020
Reconix added a commit to Reconix/joomla-cms that referenced this pull request Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants