-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[staging] Missing Web Links language strings #30253
[staging] Missing Web Links language strings #30253
Conversation
I have tested this item ✅ successfully on e880cd0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30253. |
@chmst plg_editors-xtd_weblink.ini Shall I add them here or in new patch? What you think? |
@infograf768 I was creating 2 issues (418 & 419) that are currently in this component, but no one answered. is this component currently being developed here or in another directory? |
Add it to this PR. It is an easy test |
@sanek4life |
@chmst |
I have tested this item ✅ successfully on c5aa50a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30253. |
@HLeithner |
Thanks, I'm wondering why com_weblinks translations are still in core... |
It was decided to keep the web links ini files in core for the 3x series when web links were separated as we have no structure to propose specific languages for them. |
thx for the info |
More background to language files in weblinks: joomla-extensions/weblinks#383 |
At this stage, all web links ini files are no more present in J4. |
Новые константы, вышла 3.9.21 RC joomla/joomla-cms#30221 joomla/joomla-cms#30390 (не вносил изменения, у нас "Менеджер" есть и в других местах) joomla/joomla-cms#30157 joomla/joomla-cms#30110 joomla/joomla-cms#29895 joomla/joomla-cms#30253
…)" This reverts commit 781ec36.
This reverts commit 8ef8ae4.
…)" This reverts commit 781ec36.
This reverts commit 8ef8ae4.
This reverts commit 5c708c4.
…omla#30269)"" This reverts commit 473dc70.
Summary of Changes
As title says. This PR adds strings present in last version (3.7.0) of web links.
Installing the web links package will provide the new strings but these are not present in the other languages pack as they are absent from en-GB core distribution.
Using German in backend will show the strings have not been added/translated.
Testing Instructions
Install weblinks package. https://downloads.joomla.org/extensions/weblinks/3-7-0
Switch backend to German.
Set Debug Language on
Create a weblink.
Actual result BEFORE applying this Pull Request
Example:
Expected result AFTER applying this Pull Request
As the strings will now be present (after translation by German Team in next release), they will show Ok.
The French pack does already contain these missing strings