Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix debug logging. Move logging to application #30317

Merged
merged 4 commits into from Oct 16, 2020

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Aug 8, 2020

This is try to fix Release Blocker #25675 .

Summary of Changes

This will move logging set up to application level. The plugin used only for display them.
One of new feature here, that the logging may be enabled even when the debugging is Off.

Testing Instructions

Be aware: there a thousands of Deprecated entries, if you have a slow PC / server, be patient.

Apply patch. Go to Global Configuration and enable Debug, also enable Log Deprecated API.
Enable System Debug plugin, and set "Show logs" in the plugin.

In the debugger toolbar you should be able to see much of entries of Deprecated call.

Actual result BEFORE applying this Pull Request

No Deprecated entries, or only few of them.

Expected result AFTER applying this Pull Request

A loot of entries

Documentation Changes Required

Yes I guess. Logging moved to Global configuration, and can be enabled there.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Aug 8, 2020
@richard67 richard67 changed the title [4.0] Fix debug logging. Move loging to application [4.0] Fix debug logging. Move logging to application Aug 8, 2020
Co-authored-by: Brian Teeman <brian@teeman.net>
@toivo
Copy link
Contributor

toivo commented Aug 9, 2020

I have tested this item ✅ successfully on 0275ab9

Tested successfully in Beta4-dev of 5 August on Wampserver 3.2.2 using PHP 7.4.8.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30317.

@richard67
Copy link
Member

Previous test by @toivo is still valid because last change only was a typo correction in a language string. I've restored the test result in the issue tracker.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 31e7e77


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30317.

@richard67
Copy link
Member

@Fedik To save you time, I've allowed myself to commit the typo correction for the language string directly to your branch. I hope you are ok with that. If not, let me know and I'll never do it again.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30317.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 9, 2020
@ohrionmartin
Copy link
Member

I have tested this item ✅ successfully on 31e7e77

System Information

php: Linux lamp121.cloudaccess.net 2.6.32-673.8.1.lve1.4.3.1.el6.x86_64 #1 SMP Thu May 5 16:06:47 EDT 2016 x86_64
dbserver: mysql
dbversion: 5.7.29-cll-lve
dbcollation: utf8_general_ci
dbconnectioncollation: utf8mb4_general_ci
dbconnectionencryption:
dbconnencryptsupported: true
phpversion: 7.3.19
server: Apache
sapi_name: cgi-fcgi
version: Joomla! 4.0.0-beta4-dev Development [ Mañana ] 29-July-2020 18:21 GMT
useragent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:79.0) Gecko/20100101 Firefox/79.0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30317.

@richard67
Copy link
Member

@wilsonge Anything keeps this from being merged?

@zero-24 zero-24 added this to the Joomla 4.0 milestone Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants