Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fixing Warning Alert color contrast #30382

Merged
merged 1 commit into from Aug 16, 2020

Conversation

infograf768
Copy link
Member

Pull Request for Issue #30375

Summary of Changes

As title says. Changing Warning heading and Close button to black to increase contrast with Yellow background

Testing Instructions

Try to login with a wrong password. in frontend as well as backend
You will get a warning.

NPM after patch

Actual result BEFORE applying this Pull Request

Frontend

Screen Shot 2020-08-16 at 07 14 45

Backend

Screen Shot 2020-08-16 at 07 15 16

Expected result AFTER applying this Pull Request

Frontend
Screen Shot 2020-08-16 at 06 51 11

Backend

Screen Shot 2020-08-16 at 06 46 22

@sandewt
Copy link
Contributor

sandewt commented Aug 16, 2020

Joomla! 4.0.0-beta4-dev Development [ Mañana ] 29-July-2020 18:21 GMT
Joomla_4.0.0-beta4-dev+pr.30382-Development-Full_Package.zip

Note: I miss the yellow border top of the warming message in the administrator, as it can be seen in the frontend.

See test result below.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30382.

@sandewt
Copy link
Contributor

sandewt commented Aug 16, 2020

I have tested this item ✅ successfully on 957384d

See my comment above.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30382.

@infograf768
Copy link
Member Author

Note: I miss the yellow border top of the warming message in the administrator, as it can be seen in the frontend.

This is only for the login page and the border is there, although just close to the header.
If desired, one could modify slightly the code in login.php to include <jdoc:include type="message" /> in a <div> with a specific class. Not sure it is necessary.

Thanks for testing.

@chmst
Copy link
Contributor

chmst commented Aug 16, 2020

I have tested this item ✅ successfully on 957384d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30382.

@richard67 richard67 removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Aug 16, 2020
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30382.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 16, 2020
@richard67 richard67 added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Aug 16, 2020
@infograf768 infograf768 added this to the Joomla 4.0 milestone Aug 16, 2020
@richard67 richard67 merged commit 37252dc into joomla:4.0-dev Aug 16, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 16, 2020
@richard67
Copy link
Member

Thanks to all (coder and testers).

@infograf768 infograf768 deleted the 4.0_alert_warning branch August 16, 2020 10:04
@sandewt
Copy link
Contributor

sandewt commented Aug 16, 2020

If desired, one could modify slightly the code in login.php to include <jdoc:include type="message" /> in a <div> with a specific class. Not sure it is necessary.

I have tried something with an existing class for the look and feel.
Disadvantage: the login field always scrolls down 15 px.
File: login.php

<div class="contentpane">
<jdoc:include type="message" />
</div>	

Result:
screen shot 2020-08-16 at 12 42 02

Next step?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30382.

@infograf768
Copy link
Member Author

A new class could be created in /administrator/templates/atum/scss/blocks/_login.scss
Something like

.login_message {
  margin: 1rem 1rem 0 1rem; }

code in login.php

		<section id="content" class="content h-100">
			<div class="login_message"><jdoc:include type="message" /></div>
			<main class="d-flex justify-content-center align-items-center h-100">

You can make PR.

@sandewt
Copy link
Contributor

sandewt commented Aug 17, 2020

See issue: #30400


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30382.

sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Changing Warning heading and Close button to black to increase contrast with Yellow background for accessibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants