Fix media manager when using 0 maximum file size #30572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[4.0] Remove magic quotes (joomla#24320)
Update 4.0 branch
wilsonge
approved these changes
Sep 4, 2020
|
I have tested this item ✅ successfully on 84e1f80 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30572. |
1 similar comment
|
I have tested this item ✅ successfully on 84e1f80 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30572. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30572. |
|
I have tested this item ✅ successfully on 84e1f80 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30572. |
|
Thank you! |
|
Thankyou for you first PR to joomla ❤️ |
|
Thank you, although It's not my first PR to joomla |
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
Co-authored-by: Ioannis Maliouris <giannism@e-avenue.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #30567
Summary of Changes
Check if maximum file size is set to 0 and let user upload the image, else check if file size is larger than the maximum file size and throw error
Testing Instructions
Set maximum file size to 0.
Actual result BEFORE applying this Pull Request
Can't upload any image
Expected result AFTER applying this Pull Request
Upload images as expected
Documentation Changes Required