New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Fix icons display in debug bar #30749
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
NPM Resource Changed
This Pull Request can't be tested by Patchtester
PR-4.0-dev
labels
Sep 23, 2020
I have tested this item ✅ successfully on 4485567 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30749. |
Can't replicate issue #30719 |
@N6REJ Try in backend. |
I have tested this item ✅ successfully on 4485567 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30749. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30749. |
richard67
removed
NPM Resource Changed
This Pull Request can't be tested by Patchtester
PR-4.0-dev
labels
Sep 24, 2020
richard67
added
NPM Resource Changed
This Pull Request can't be tested by Patchtester
PR-4.0-dev
labels
Sep 24, 2020
Thanks! |
dgrammatiko
added a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Sep 26, 2020
* Joomla/4.0-dev: (844 commits) [4.0] Template layout select (joomla#30772) [4.0][CLI] com_finder use console command (joomla#30768) [4.0] Modifying com_actionlogs string (joomla#30758) [4.0] Fancy selectbox fix (joomla#30739) [4.0] Add missing Table Caption (joomla#30763) [4.0] Wrap all buttons in btn-group to improve styling (joomla#30761) [4.0] Cassiopeia missing string (joomla#30765) Improve batch text (joomla#28447) Fix icons not displaying (joomla#30749) Remove the chrome "cardGrey". The same effect can be achieved by using the module class "card-grey" with the "card" chrome (joomla#30734) Remove obsolete html code (joomla#30737) [4.0] Check out improvements related to nullable columns (joomla#30747) Removing card.scss overrides as we don't use those classes Use renderField() method to render fields (joomla#30738) [4.0] spelling (joomla#30742) [4.0] Remove use of ReflectionParameter::getClass() (joomla#30581) [4.0] Fix saving images (joomla#30730) [4.0] Cleanup cassiopeia chromes and rename "default" to "card" (joomla#30729) Fix hiddenLabel and add hiddenLegend form attribute (joomla#29710) [4.0] Fix Debug plugin to display query parameters (joomla#30717) ...
dgrammatiko
added a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Sep 29, 2020
…ger_events_consistency * '4.0-dev' of github.com:joomla/joomla-cms: (84 commits) [4.0] Error in legacy plugins when method contains $event argument (joomla#30575) [4.0] Cassiopea table css (joomla#30740) [4.0] Blog view links (joomla#30788) Change grid minmax definition for newsflash module (joomla#30781) [4.0] Pluginless lazyloading for the core (joomla#30748) Update package-lock.json (joomla#30713) [4.0] mod_article_news readmore (joomla#30780) Improve code, remove separator (joomla#30785) [4.0] Template layout select (joomla#30772) [4.0][CLI] com_finder use console command (joomla#30768) [4.0] Modifying com_actionlogs string (joomla#30758) [4.0] Fancy selectbox fix (joomla#30739) [4.0] Add missing Table Caption (joomla#30763) [4.0] Wrap all buttons in btn-group to improve styling (joomla#30761) [4.0] Cassiopeia missing string (joomla#30765) Improve batch text (joomla#28447) Fix icons not displaying (joomla#30749) Remove the chrome "cardGrey". The same effect can be achieved by using the module class "card-grey" with the "card" chrome (joomla#30734) Remove obsolete html code (joomla#30737) [4.0] Check out improvements related to nullable columns (joomla#30747) ... � Conflicts: � administrator/components/com_media/resources/scripts/app/Api.js � administrator/components/com_media/resources/scripts/components/toolbar/toolbar.vue � package-lock.json
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #30719 .
Summary of Changes
Add font weight where the missing icons exist.
Testing Instructions
Install PR
Run npm i
or
Download the installer package at the bottom of the page.
Enable Debug System under Global Configuration > System
Click Queries in footer.
Actual result BEFORE applying this Pull Request