Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] size of the template name font in module position selector #30890

Merged
merged 1 commit into from
Oct 4, 2020

Conversation

brianteeman
Copy link
Contributor

PR for #30844

The heading should be visibly disabled larger than the items

before

image

after

image

testing

dont forget npm ci or node build.js --compile-css

…lector

PR for joomla#30844

The ehading should be visibly disabled larger than the items

### before

### after

### testing
dont forget npm ci or node build.js --compile-css
@Scrabble96
Copy link
Contributor

I have tested this successfully but I don't know how to add a green tick/check mark or reference the commit. Sorry.

@adj9
Copy link

adj9 commented Oct 3, 2020

I have not tested this item.

I tried but visually I do not notice any difference. I cannot apply npm.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30890.

@Scrabble96
Copy link
Contributor

I have not tested this item.

I tried but visually I do not notice any difference. I cannot apply npm.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30890.

I didn't do anything with npm ci or node build.js -- complile-css either.

I tested this by using the PR zip update package which I got by clicking on 'Show all checks' next to "Some checks haven't completed yet" then selecting 'Details' next to "Download - prebuilt packages are available for download" then downloaded the update package zip, installed it on my test site and then looked at the module positions. I saw exactly as @brianteeman has shown in his screenshots. As I said above, though, I don't know how to confirm this as a successful test. If you can tell me I'd be very grateful.

@brianteeman
Copy link
Contributor Author

Record your test here https://issues.joomla.org/tracker/joomla-cms/30890.

@Scrabble96
Copy link
Contributor

I have tested this item ✅ successfully on 0b1dce0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30890.

@Scrabble96
Copy link
Contributor

Record your test here https://issues.joomla.org/tracker/joomla-cms/30890.

Thank you :-)

@HLeithner
Copy link
Member

@adj9 you can always use the prebuilt packages to test an pr like this.

image

@HLeithner HLeithner merged commit 39373b7 into joomla:4.0-dev Oct 4, 2020
@HLeithner
Copy link
Member

Tested by my self thanks

@HLeithner HLeithner added this to the Joomla 4.0 milestone Oct 4, 2020
@brianteeman
Copy link
Contributor Author

thanks

@brianteeman brianteeman deleted the yk20 branch October 4, 2020 13:32
dgrammatiko added a commit to dgrammatiko/joomla-cms that referenced this pull request Oct 4, 2020
…ue-cs

* '4.0-dev' of github.com:joomla/joomla-cms: (22 commits)
  [4.0] Change the size of the template name font in module position selector (joomla#30890)
  [4.0] Media Manager close preview (joomla#30851)
  [4.0] sticky sidebar menu (joomla#30853)
  [4.0] treeselect alerts (joomla#30854)
  [4.0] Fix pagebreak modal missing style (joomla#30889)
  [4.0] xtd-editor button for module (joomla#30892)
  [4.0] Templates: Styles (Administrator) menu color changes on save (joomla#30847)
  Namespace (joomla#30865)
  [4.0] Fall back to system template when template file not found (joomla#30857)
  [4.0] joomla update show password (joomla#30849)
  [4.0] com_media options (joomla#30852)
  [4.0] Update lib_joomla.ini (joomla#30867)
  [4.0] Missing js file in joomla#30813 (joomla#30859)
  [4.0] Site Contacts Category List Search Filters (joomla#30813)
  [4.0] Article Links markup (joomla#30824)
  [4.0] Language reinstall (joomla#30810)
  [4.0] tinmyce toolbar icons (joomla#30825)
  [4.0] hidden-xs-up (joomla#30837)
  Update com_mails.ini (joomla#30842)
  [4.0] Add css style for mod_articles_news vertical layout (joomla#30797)
  ...

# Conflicts:
#	administrator/components/com_media/resources/scripts/components/modals/modal.vue
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants