Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0] Site Contacts Category List Search Filters #30813

Merged
merged 3 commits into from
Oct 2, 2020
Merged

[4.0] Site Contacts Category List Search Filters #30813

merged 3 commits into from
Oct 2, 2020

Conversation

infograf768
Copy link
Member

Summary of Changes

Adding Search Filter and Clear buttons to the List Contacts in a Category menu item.
Modify the placeholder string to specify the search is limited to the Contact Title.

Testing Instructions

Create multiple contacts in the same category.
Create a List Contacts in a Category menu item for this category.
Make sure Filter Field is set to Show in the menu parameters.
Display the menu item in frontend.

Actual result BEFORE applying this Pull Request

Screen Shot 2020-09-30 at 12 53 06

Expected result AFTER applying this Pull Request

contact-search

Note

  1. With a similar PR, we can add a Clear filter button in the List Articles in a Category menu item
  2. It would be nice to add css for the Clear button in order to display a different color when the filter field is empty and not. I guess this would be for the Cassiopea Team to deal with.

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Sep 30, 2020
@infograf768 infograf768 mentioned this pull request Oct 1, 2020
Merged
@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label Oct 1, 2020
@brianteeman
Copy link
Contributor

Thanks for that last change to use sr-only - I was about to comment and got distracted

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 9da66d3

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30813.

@infograf768
Copy link
Member Author

Note:
1.

Thanks for that last change to use sr-only - I was about to comment and got distracted

We will need to do the same for articles list. Will modify that in the new PR if this PR is accepted and merged.

  1. We have to be able to modify the number of items displayed in the list by using the limit box.
    It is impossible right now because the code forces $limit value to the parameters set in contact Options and the menu item, contrary to articles.
    I have a patch for that. Will propose later.

@infograf768 infograf768 mentioned this pull request Oct 1, 2020
Merged
@jwaisner
Copy link
Member

jwaisner commented Oct 1, 2020

I have tested this item ✅ successfully on 9da66d3

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30813.

@jwaisner
Copy link
Member

jwaisner commented Oct 1, 2020

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30813.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 1, 2020
@wilsonge wilsonge merged commit 2110e63 into joomla:4.0-dev Oct 2, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 2, 2020
@wilsonge
Copy link
Contributor

wilsonge commented Oct 2, 2020

Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Oct 2, 2020
infograf768 added a commit to infograf768/joomla-cms that referenced this pull request Oct 2, 2020
@infograf768
[4.0] Missing js file in joomla#30813
6120ebb
@infograf768 infograf768 mentioned this pull request Oct 2, 2020
Merged
HLeithner pushed a commit that referenced this pull request Oct 2, 2020
@infograf768
[4.0] Missing js file in #30813 (#30859)
ce55812 
* [4.0] Missing js file in #30813

* missing new line
@infograf768 infograf768 deleted the 4.0_sitecontactlistfiltering branch October 2, 2020 07:10
@infograf768 infograf768 mentioned this pull request Oct 2, 2020
Merged
dgrammatiko added a commit to dgrammatiko/joomla-cms that referenced this pull request Oct 2, 2020
@dgrammatiko
Merge branch '4.0-dev' of github.com:joomla/joomla-cms into 4.0-dev-j…
b8f5ba3 
…s-cs

* '4.0-dev' of github.com:joomla/joomla-cms:
  [4.0] Templates: Styles (Administrator) menu color changes on save (joomla#30847)
  Namespace (joomla#30865)
  [4.0] Fall back to system template when template file not found (joomla#30857)
  [4.0] joomla update show password (joomla#30849)
  [4.0] com_media options (joomla#30852)
  [4.0] Update lib_joomla.ini (joomla#30867)
  [4.0] Missing js file in joomla#30813 (joomla#30859)
  [4.0] Site Contacts Category List Search Filters (joomla#30813)
  Add update SQL script for previous 4.0 beta versions
  Dont use id in WHERE clause for updating menu items in update SQL script
@jgerman-bot jgerman-bot mentioned this pull request Oct 2, 2020
Closed
@infograf768 infograf768 mentioned this pull request Oct 3, 2020
Merged
@infograf768
Copy link
Member Author

Concerning the list limit issue, please test #30904

dgrammatiko added a commit to dgrammatiko/joomla-cms that referenced this pull request Oct 4, 2020
@dgrammatiko
Merge branch '4.0-dev' of github.com:joomla/joomla-cms into 4.0-dev-v…
e2a30c2 
…ue-cs

* '4.0-dev' of github.com:joomla/joomla-cms: (22 commits)
  [4.0] Change the size of the template name font in module position selector (joomla#30890)
  [4.0] Media Manager close preview (joomla#30851)
  [4.0] sticky sidebar menu (joomla#30853)
  [4.0] treeselect alerts (joomla#30854)
  [4.0] Fix pagebreak modal missing style (joomla#30889)
  [4.0] xtd-editor button for module (joomla#30892)
  [4.0] Templates: Styles (Administrator) menu color changes on save (joomla#30847)
  Namespace (joomla#30865)
  [4.0] Fall back to system template when template file not found (joomla#30857)
  [4.0] joomla update show password (joomla#30849)
  [4.0] com_media options (joomla#30852)
  [4.0] Update lib_joomla.ini (joomla#30867)
  [4.0] Missing js file in joomla#30813 (joomla#30859)
  [4.0] Site Contacts Category List Search Filters (joomla#30813)
  [4.0] Article Links markup (joomla#30824)
  [4.0] Language reinstall (joomla#30810)
  [4.0] tinmyce toolbar icons (joomla#30825)
  [4.0] hidden-xs-up (joomla#30837)
  Update com_mails.ini (joomla#30842)
  [4.0] Add css style for mod_articles_news vertical layout (joomla#30797)
  ...

# Conflicts:
#	administrator/components/com_media/resources/scripts/components/modals/modal.vue
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
@infograf768 @sakiss
[4.0] Site Contacts Category List Search Filters (joomla#30813)
4470852
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
@infograf768 @sakiss
[4.0] Missing js file in joomla#30813 (joomla#30859)
250622d 
* [4.0] Missing js file in joomla#30813

* missing new line
@brianteeman brianteeman mentioned this pull request Apr 7, 2021
Merged
richard67 pushed a commit that referenced this pull request Apr 9, 2021
@brianteeman @joomdonation
[4.0] Contact Category list limits (#33050)
ae640ed 
PR for #33021

Hopefully this resolves the bug reported with #30813.
#30904 tried to fix it by removing the feature introduced with #23710 completely which was wrong

Co-authored-by: Tuan Pham Ngoc <github@joomdonation.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Milestone
Joomla 4.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@infograf768 @brianteeman @jwaisner @wilsonge @joomla-cms-bot