Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] frontend articles category list improvements #31373

Merged
merged 5 commits into from
Nov 14, 2020

Conversation

infograf768
Copy link
Member

@infograf768 infograf768 commented Nov 10, 2020

Pull Request for Issue #31367

Summary of Changes

Added scope row.
Taking off useless headers="categorylist_header_WHATEVER"
Display Written by and Hits in badge only when table headings are set to No in the list layout parameters.

Testing Instructions

Create some articles in the same category.Create a category list menu item.
Switch Table Headings to yes and no
Load menu item in frontend.

Actual result BEFORE applying this Pull Request

tableheadingsbefore

Expected result AFTER applying this Pull Request

tableheadings after

Screen Shot 2020-11-10 at 07 42 34

@toivo
Copy link
Contributor

toivo commented Nov 10, 2020

I have tested this item ✅ successfully on 094f67e

Tested successfully in Beta6-dev of 10 November.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31373.

@infograf768
Copy link
Member Author

scope row now moved.
@toivo test is still OK as it does not change display.

@chmst
Copy link
Contributor

chmst commented Nov 10, 2020

I have tested this item ✅ successfully on 7b61f7c

Not tested for voting columns


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31373.

@infograf768
Copy link
Member Author

td modified to th as required

Also modified the display for Votes and Ratings depending on Table Headings display

Screen Shot 2020-11-12 at 09 34 44

Screen Shot 2020-11-12 at 09 34 22

Ratings should be displayed as stars in the same way as when displaying an article. No idea how to do that as we can have multiple onContentBeforeDisplay or onContentAfterDisplay methods in different plugins.
Therefore I left it as it was.

@chmst @Quy Please test again

@chmst
Copy link
Contributor

chmst commented Nov 12, 2020

I have tested this item ✅ successfully on 767c447


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31373.

@infograf768
Copy link
Member Author

@toivo
Please test again.

@toivo
Copy link
Contributor

toivo commented Nov 14, 2020

I have tested this item ✅ successfully on 767c447

Tested successfully in Beta6-dev of 14 November.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31373.

@infograf768
Copy link
Member Author

As last change was just deleting a forgotten headers, RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31373.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 14, 2020
@infograf768 infograf768 added this to the Joomla 4.0 milestone Nov 14, 2020
@richard67 richard67 merged commit 09bbb15 into joomla:4.0-dev Nov 14, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 14, 2020
@richard67
Copy link
Member

Thanks!

@infograf768 infograf768 deleted the 4.0_cat_articles_list branch November 14, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants