Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Tinmyce image decorative [a11y] #31389

Merged
merged 2 commits into from
Nov 12, 2020
Merged

[4.x] Tinmyce image decorative [a11y] #31389

merged 2 commits into from
Nov 12, 2020

Conversation

brianteeman
Copy link
Contributor

This PR enables the native tinymce feature to mark an image as decorative. This continues the work started in #31318 and #31323

Background

To read why this change is very important see #31318

Testing Part 1

Testing is really easy. No npm, js or css involved.
Merge the pull request and then use the tinmyce image button to add an image
image

The new options is highlighted here
image

Testing Part 2

Please test three scenarios

  1. Image Description (Alt Text) = Empty
    Images is decorative = unchecked

  2. Image Description (Alt Text) = "some description"
    Images is decorative = unchecked

  3. Image Description (Alt Text) = Empty
    Images is decorative = checked

The expected behaviour for each of these tests is

1.<img src="filename.jpg" width="xx" height="xx" />
2. <img src="filename.jpg" alt="some description" width="xx" height="xx" />
3. <img role="presentation" src="filename.jpg" alt width="xx" height="xx" />
3. <img role="presentation" src="filename.jpg" alt="" width="xx" height="xx" />

PLEASE do not comment on what you think the code does but apply the PR and test it. Getting very tired of people blocking PR with their comments without actually testing the code.

Bonus

I have grouped the three image options together in the code.

cc @carcam

This PR enables the native tinymce feature to mark an image as decorative. This continues the work started in joomla#31318 and joomla#31323
@brianteeman brianteeman changed the title [4.x] Tinmyce image decorative [4.x] Tinmyce image decorative [a11y] Nov 12, 2020
@pabloarias
Copy link

pabloarias commented Nov 12, 2020

I have tested this item ✅ successfully on a7eace8

I've tested it successfully with Joomla 4 beta 6 daily build. This is the result:

1. <img src="images/joomla_black.png" width="225" height="50" />
2. <img src="images/joomla_black.png" alt="some description" width="225" height="50" />
3. <img role="presentation" src="images/joomla_black.png" alt="" width="225" height="50" />

Thank you!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31389.

@maikol-ortigueira
Copy link

I have tested this item ✅ successfully on a7eace8

I have tested this item and it works perfectly.
Thank you.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31389.

@alikon
Copy link
Contributor

alikon commented Nov 12, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31389.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 12, 2020
@Quy Quy added the PR-4.0-dev label Nov 12, 2020
@chmst chmst added this to the Joomla 4.0 milestone Nov 12, 2020
@chmst chmst merged commit d48d18b into joomla:4.0-dev Nov 12, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 12, 2020
@chmst
Copy link
Contributor

chmst commented Nov 12, 2020

Thanks!

@brianteeman
Copy link
Contributor Author

Thanks

@brianteeman brianteeman deleted the tiny branch November 12, 2020 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants