Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Accessible media field ALt Text #31323

Merged
merged 3 commits into from
Nov 7, 2020
Merged

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Nov 6, 2020

This PR continues the awesome work of @astridx in #27712 by correcting the behaviour of the alt text and changing the strings to match the work done in #31318

Background

To read why this change is very important see #31318

Testing Part 1

Testing is really easy. No npm, js or css involved.
Merge the pull request and then create a content field of type media (default settings are fine)
Open an article the media field now has a third field and tweaked text to match #31318

Before

image

After

image

Testing Part 2

Please test three scenarios when adding an image

  1. Image Description (Alt Text) = Empty
    No Description = unchecked

  2. Image Description (Alt Text) = "some description"
    No Description = unchecked

  3. Image Description (Alt Text) = Empty
    No Description = checked

The expected behaviour for each of these tests is

1.<img loading="lazy" src="filename.jpg">
2. <img loading="lazy" src="filename.jpg" alt="some description">
3. <img loading="lazy" src="filename.jpg" alt >
or <img loading="lazy" src="filename.jpg" alt="">

PLEASE do not comment on what you think the code does but apply the PR and test it. Getting very tired of people blocking PR with their comments without actually testing the code.

cc @carcam

This PR continues the awesome work of @astridx in joomla#27712 by correcting the behaviour of the alt text and changing the strings to match the work done in joomla#31318
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Nov 6, 2020
Co-authored-by: Quy <quy@fluxbb.org>
@Quy
Copy link
Contributor

Quy commented Nov 6, 2020

How about using a switcher instead checkbox to show the Alt Text field when unchecked?

@brianteeman
Copy link
Contributor Author

brianteeman commented Nov 6, 2020 via email

@pranotiTechjoomla
Copy link

I have tested this item ✅ successfully on bfdc890


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31323.

@snehaM26
Copy link

snehaM26 commented Nov 7, 2020

I have tested this item ✅ successfully on bfdc890

I have tested this item.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31323.

@alikon
Copy link
Contributor

alikon commented Nov 7, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31323.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 7, 2020
@chmst chmst merged commit a140913 into joomla:4.0-dev Nov 7, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 7, 2020
@chmst chmst added this to the Joomla 4.0 milestone Nov 7, 2020
@chmst
Copy link
Contributor

chmst commented Nov 7, 2020

Thanks!

@brianteeman
Copy link
Contributor Author

Thanks - just need all the others to be written and merged now.

@brianteeman brianteeman deleted the imagefield branch November 7, 2020 11:10
brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request Nov 12, 2020
This PR enables the native tinymce feature to mark an image as decorative. This continues the work started in joomla#31318 and joomla#31323
chmst pushed a commit that referenced this pull request Nov 12, 2020
* [4.x] Tinmyce image decorative

This PR enables the native tinymce feature to mark an image as decorative. This continues the work started in #31318 and #31323
richard67 pushed a commit that referenced this pull request Nov 14, 2020
Continues the work of #31318 and #31323 by correcting the behaviour of the alt text and changing the strings to match the work done in #31318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants