-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Accessible media field ALt Text #31323
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR continues the awesome work of @astridx in joomla#27712 by correcting the behaviour of the alt text and changing the strings to match the work done in joomla#31318
Quy
reviewed
Nov 6, 2020
Co-authored-by: Quy <quy@fluxbb.org>
How about using a switcher instead checkbox to show the Alt Text field when unchecked? |
No thanks
…On Fri, 6 Nov 2020 at 16:58, Quy ***@***.***> wrote:
How about using a switcher instead checkbox to show the Alt Text field
when unchecked?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#31323 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ4P4JO6EEA53ZPQ6B7TITSOQTMXANCNFSM4TMO6BLA>
.
--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ <http://brian.teeman.net/>
|
I have tested this item ✅ successfully on bfdc890 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31323. |
I have tested this item ✅ successfully on bfdc890 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31323. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31323. |
Thanks! |
Thanks - just need all the others to be written and merged now. |
This was referenced Nov 7, 2020
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Nov 12, 2020
This PR enables the native tinymce feature to mark an image as decorative. This continues the work started in joomla#31318 and joomla#31323
chmst
pushed a commit
that referenced
this pull request
Nov 12, 2020
richard67
pushed a commit
that referenced
this pull request
Nov 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues the awesome work of @astridx in #27712 by correcting the behaviour of the alt text and changing the strings to match the work done in #31318
Background
To read why this change is very important see #31318
Testing Part 1
Testing is really easy. No npm, js or css involved.
Merge the pull request and then create a content field of type media (default settings are fine)
Open an article the media field now has a third field and tweaked text to match #31318
Before
After
Testing Part 2
Please test three scenarios when adding an image
Image Description (Alt Text) = Empty
No Description = unchecked
Image Description (Alt Text) = "some description"
No Description = unchecked
Image Description (Alt Text) = Empty
No Description = checked
The expected behaviour for each of these tests is
1.
<img loading="lazy" src="filename.jpg">
2.
<img loading="lazy" src="filename.jpg" alt="some description">
3.
<img loading="lazy" src="filename.jpg" alt >
or
<img loading="lazy" src="filename.jpg" alt="">
PLEASE do not comment on what you think the code does but apply the PR and test it. Getting very tired of people blocking PR with their comments without actually testing the code.
cc @carcam