Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod submenu fix display of Components dashboard Dashboard icons #31391

Merged
merged 9 commits into from
Nov 14, 2020
Merged

Mod submenu fix display of Components dashboard Dashboard icons #31391

merged 9 commits into from
Nov 14, 2020

Conversation

ceford
Copy link
Contributor

@ceford ceford commented Nov 12, 2020

Pull Request for Issue # .

Problem identified in #31382

Summary of Changes

Correct display and title of Component Dashboard display of a Dashboard icon

Testing Instructions

Obtain and install this dummy component: https://github.com/Harmageddon/com_demoj4
Go to Components Dashboard

Actual result BEFORE applying this Pull Request

image
And the title is shown as %s Dashboard

Expected result AFTER applying this Pull Request

image
And the Ttile is shown as J4 Demonstration Component Dashboard

Documentation Changes Required

None

@Harmageddon
Copy link
Contributor

I have not tested this item.

Good spot! Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31391.

@brianteeman
Copy link
Contributor

brianteeman commented Nov 12, 2020

I have installed the component for testing as instructed

BEFORE applying the patch the title is correct and not as you describe - am I looking in the wrong place?

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 51473dc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31391.

1 similar comment
@ChristineWk
Copy link

I have tested this item ✅ successfully on 51473dc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31391.

@Harmageddon
Copy link
Contributor

I have tested this item ✅ successfully on 51473dc

No idea what happened to my test, hope it works now.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31391.

@Quy Quy removed the PR-4.0-dev label Nov 12, 2020
@Quy
Copy link
Contributor

Quy commented Nov 12, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31391.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 12, 2020
@Quy Quy added the PR-4.0-dev label Nov 12, 2020
@Quy Quy added this to the Joomla 4.0 milestone Nov 12, 2020
@richard67 richard67 merged commit 0129c9b into joomla:4.0-dev Nov 14, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 14, 2020
@richard67
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants