Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Disabled dropdown styling #31394

Merged
merged 3 commits into from
Nov 14, 2020
Merged

Conversation

brianteeman
Copy link
Contributor

Pr for #29953

Summary of Changes

Ensure that a disabled dropdown select really looks disabled

Testing Instructions

Joomla 4.0-dev
Login to admin as super admin
Navigate Content -> Fields
Create a new text field - click save

Look at the Type dropdown

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

none

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Nov 13, 2020
@Quy
Copy link
Contributor

Quy commented Nov 13, 2020

I have tested this item ✅ successfully on 4838308


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31394.

@ceford
Copy link
Contributor

ceford commented Nov 14, 2020

I have tested this item ✅ successfully on 4838308

Needs npm ci - forgot the command to compile just css


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31394.

@Quy
Copy link
Contributor

Quy commented Nov 14, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31394.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 14, 2020
@richard67 richard67 merged commit abf5cf4 into joomla:4.0-dev Nov 14, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 14, 2020
@richard67
Copy link
Member

Thanks!

@richard67 richard67 added this to the Joomla 4.0 milestone Nov 14, 2020
@richard67
Copy link
Member

Needs npm ci - forgot the command to compile just css

@ceford npm run build:js for js and npm run build:css for CSS.

@brianteeman brianteeman deleted the disabled_field branch December 7, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants