-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Check for empty client com_banners #31411
Conversation
@brianteeman Do I understand right that this PR here makes PR #31354 obsolete? |
With spaces in Name or in Contact Name the error message says in both cases:
Can it be adjusted to say Name or Contact Name as appropriate? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31411. |
it could be - means more strings for translators - is it really needed? |
Why this PR? Also: JLIB_CMS_WARNING_PROVIDE_VALID_NAME uses the wording Note: instructions are wrong as this does not concern article. |
Sorry I didnt see the other PR - I just saw two open issues and wrote a PR to fix them - there was no reference on those issues |
If the try/catch is useless in #31354, please ask there to modify. |
As I said already I did not see the other PR as no one had referenced it on the issues and the issues were left open |
The other PR is from a new contributor, so maybe that's why it didn't reference the issues, or only one of them. Sure we should try not to discourage him, but if it is better to use this PR here then I can try to find some nice words there and ask him to close his PR. |
I looked into how to solve this problem client side. It would be nice if we could get a Javascript guru to take this on: Add class="validate-notwhite" to any form field that is required but must not be white space. As an experiment, put this in the code that displays the form:
It would need something else for a field that is not required but if used must not be white space. |
I have tested this item ✅ successfully on b2e0bf8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31411. |
I have tested this item ✅ successfully on b2e0bf8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31411. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31411. |
Imho I don’t think this pr is better than the other one. |
Pull Request for Issue #31345 and #31355
Summary of Changes
Adds a check to ensure that the client name can not be saved with just blank characters
Adds a check to ensure that the contact name can not be saved with just blank characters
Testing Instructions
Repeat above for Client Name
Actual result BEFORE applying this Pull Request
Article is saved
Expected result AFTER applying this Pull Request
Article is not saved with error message saying why
Documentation Changes Required
none