[4.0] Fix for Lazyloading bad url

[dgrammatiko]

Pull Request for Issue #31509 .

Summary of Changes

Fixing bad URL (front end links replace & with &, my bad never tested that case

Testing Instructions

Try to add an image to a menuItem or to the offline page.

Expected == Actual result

The image is selected and the image name is stored in the parameter images.

Documentation Changes Required

@wilsonge just FWIW the new URL with the extra 2 params will always fail for code like: <?php if ($app->get('offline_image') && file_exists($app->get('offline_image'))) : ?> (interpreting the URL as a file path). I think this is something that needs to be communicated. (it's not that bad, removing the file_exists, will get you back to 100% compatibility, eg a URL with the extra params that works fine but a better and safer way out is to use the HTMLHelper::image as the tag will be inserted only if the file exists).

[chmst]

I have tested this item ✅ successfully on af9be28

I have tested successfully with menus, contact, articles and offline page.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31511.}

[ceford]

I have tested this item ✅ successfully on af9be28

Checked both menu and off-line page - image present and correct.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31511.}

[richard67]

System test failure in Drone seems not to be related to this PR. It seems to be a problem with our testing environment.

[chmst]

RTC

[richard67]

@SharkyKZ Why thumbs down? (curious)

[laoneo]

Thanks!