Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] com_users webauthn svg #31824

Merged
merged 1 commit into from
Jan 2, 2021
Merged

[4.0] com_users webauthn svg #31824

merged 1 commit into from
Jan 2, 2021

Conversation

brianteeman
Copy link
Contributor

The code that was added to the login module to support the svg icon for webauthn was missing for the users component

Testing Instructions

Compare the login module and the user login menu item in the front end on a site with https

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

The code that was added to the login module to support the svg icon for webauthn was missing for the users component
@ChristineWk
Copy link

I have tested this item ✅ successfully on efc2eda


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31824.

1 similar comment
@ghost
Copy link

ghost commented Jan 2, 2021

I have tested this item ✅ successfully on efc2eda


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31824.

@alikon
Copy link
Contributor

alikon commented Jan 2, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31824.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 2, 2021
@infograf768
Copy link
Member

The patch works. No problem.
But, if #31545 is merged, then it would have to be modified.

@N6REJ
Copy link
Contributor

N6REJ commented Jan 2, 2021

@infograf768 that depends if #31190 is reverted or not. So now we have 4 issues on hold sigh

@brianteeman
Copy link
Contributor Author

This should be merged as it fixes a problem right now. A new PR can always be created later if needed as a result of any other PR

@wilsonge wilsonge merged commit 8fc1b38 into joomla:4.0-dev Jan 2, 2021
@wilsonge
Copy link
Contributor

wilsonge commented Jan 2, 2021

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 2, 2021
@wilsonge wilsonge added this to the Joomla 4.0 milestone Jan 2, 2021
@brianteeman
Copy link
Contributor Author

thanks

@brianteeman brianteeman deleted the webauthn branch January 2, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants