New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Markdown content entry #31911
[4.0] Markdown content entry #31911
Conversation
I have tested this item ✅ successfully on 9ee149b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31911. |
I have tested this item ✅ successfully on 9ee149b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31911. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31911. |
imho his needs a description with example as the label is not enough to understand what this field means. |
Also, it is a new feature, and therefore not for 4.0 To understand fully what it meant, I had to go to https://fr.wikipedia.org/wiki/Markdown (for French details) |
Good feature. But only few users will know what it means and how to use it. I agree with @infograf768 that this needs good description. |
Also, one has to understand that if the field is set to yes, then when one wants to write a specific markdown code NOT as a markdown, he/she will get weird results This means that the description should include a link to a page like the one in wikipedia, which has equivalent pages for most languages so that Translators can add custom link. |
Something like After discussion in Maintainers chat, setting this back to pending. |
Pending This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31911. |
In fact wikipedia, although explaining what is markdown, does not explain which patterns can be used In English only, alas. |
As stated in the original post this needs documentation which I will write As for the undesired consequences - thats why its not enabled by default although its unlikely to cause any problems As for it being a new feature. Its not really as we are already shipping the code I have just enabled the ability to use it. Or in other words fixed a bug that new features in tinymce were not considered when this new version was introduced in joomla 4 While this might be a really minor change its the sort of thing that appeals to users and is a more marketable feature than most oif the changes in j4 |
if everything is considered a new feature....and have to wait till 4.1, while we are still in beta... |
This is not enough. We need a description to alert the user about the feature, as stated above. |
Sorry, for me it is not enough... If I had not seen this PR and looked for Markdown on the internet I would have no idea what it is for. And, as I wrote, it should be an alert to the user that this may interact with usual TinyMCE behaviour in case some of this markup syntax is undesired. |
I guess that you have never used markdown on github or the issue tracker then. I can't fix that. |
Also, at reading the wikipedia article, I looks like |
No point in me changing that as you will still object to moving into the 21st century |
I use some of them but I did not even know the name of that functionality.
That is an argument you and some others repeat all the time when someone does not agree, and it is frankly insulting. |
Exactly. Peace please :-) Never used Markdown before. A few months ago, I asked someone what this was for. Then got information that it is used here on Github. Then I saw this PR and tried it out. The instructions for this were helpful to me as well as the gif. Otherwise I would not have known how to get to this result. For me this PR was to test the function. Of course, I can't say whether I'll ever use it in conjunction with Editor. |
that would be the basis of the documentation
100% not for everyone. It's something some 3pd editors offer and as we already shipped the library it made sense to make it available to those that might want it. |
My 2c: this PR should be part of J4. Markdown is a welcome addition to the editing capabilities in Joomla, useful not only to those who have used editors at docs.joomla.org and wikipedia.org. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31911. |
I have tested this item ✅ successfully on 5588789 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31911. |
Fine with that. I was wrong stating it can be considered as new feature. Nevertheless, we need a description with a real meaning/warning. |
I have tested this item ✅ successfully on 5588789 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31911. |
Co-authored-by: Quy <quy@fluxbb.org>
Let's go with it. We can update the description as required as we go |
Thanks - I will update the docs site tomorrow |
Summary of Changes
Adds the ability to use markdown style content editing with tinymce
This is disabled by default.
Testing Instructions
Apply the PR
In the tinymce plugin select SET 0
Scroll down and turn ON the markdown style editing
Save and close and then open an article
Insert standard markdown. As soon as you press space or enter the content will be rendered as html. It is always saved as html.
Supported markdown
Expected result AFTER applying this Pull Request
Editor
Plugin
Documentation Changes Required
yes