[4.0] sass deprecations #32144
Merged
[4.0] sass deprecations #32144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://sass-lang.com/documentation/breaking-changes/color-units Compiling the scss with this updated version produced a lot of deprecation warnings. After updating the variables with their recommendations there are no more deprecation warnings. I ran a diff between the template.css before and after and there were no changes so the changes have no impact.
joomla-cms-bot
added
NPM Resource Changed
This was referenced Jan 24, 2021
Closed
|
I have tested this item ✅ successfully on 6134bf2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32144. |
1 similar comment
|
I have tested this item ✅ successfully on 6134bf2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32144. |
richard67
removed
NPM Resource Changed
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32144. |
richard67
added
NPM Resource Changed
|
I have tested this item ✅ successfully on 6134bf2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32144. |
|
tks |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sass-lang.com/documentation/breaking-changes/color-units
Compiling the scss with this updated version produced a lot of deprecation warnings.
After updating the variables with their recommendations there are no more deprecation warnings.
I ran a diff between the template.css before and after and there were no changes so the changes have no impact.
Pull Request for Issue #32111