-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Hard coded spaces #32244
[4.0] Hard coded spaces #32244
Conversation
It's 2021 and we really should be using css and not spaces for layout. This example PR is for the language layout and replaces the hard coded space with the correct css class of me-1. (because of the new BS5 classes this is RTL aware)
@ciar4n can I get your steer on this please. I don’t have enough understanding of pros/cons to make an informed enough decision |
The only reason I can think of for why the space was misused for layout was that prior to bootstrap 5 it would have needed different classes for LTR and RTL |
Thanks @ciar4n it looks like it was just done to avoid using css as the majority of instances of using a space for layout are all related |
Then go for it |
I will do when I get the opportunity. Doesnt hold back the merge of this PR |
I have tested this item ✅ successfully on 2ba5ac9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32244. |
Note while testing this in RTL: Any volunteer to make general PR? PS: Yes, I know it is unrelated to this PR. |
Similar to joomla#32244 this p[r replaces a hard coded space with a margin. In addition it removes text-center from the column to aid readability
I have tested this item ✅ successfully on 2ba5ac9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32244. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32244. |
Thanks |
thank you |
Similar to #32244 this p[r replaces a hard coded space with a margin. In addition it removes text-center from the column to aid readability
It's 2021 and we really should be using css and not spaces for layout. This example PR is for the language layout and replaces the hard coded space with the correct css class of me-1. (because of the new BS5 classes this is RTL aware)
If accepted there are plenty of places to update