[4.0] RTL: bootstrap5 rtl overrides (Atum) #32166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
NPM Resource Changed
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #32113
Summary of Changes
Created a new
_bootstrap-rtl.scssfile loaded bytemplate-rtl.scssin AtumMoved the bootstrap specific classes from
template-rtl.scssto the new file.Added necessary rtl bootstrap5 classes in this new file. Some are not yet used in core but may be in the future.
This may not be exhaustive. If necessary, some classes may be added in the file. For example for
@mediatwists.Testing Instructions
patch
run npm ci
Install Persian fa-IR language and switch to Persian in back-end.
test multiple aspects of the admin UI.
Actual result BEFORE applying this Pull Request
An example of the corrected results in admin template editing=>description tab:
Reference: LTR
RTL:
Expected result AFTER applying this Pull Request
NOTE
This could be an example to follow for Cassiopea
@drmenzelit @brianteeman @chmst