[4.0] [RTL] Adding specific bootstrap-rtl.scss to Cassiopea #32297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
NPM Resource Changed
Closed
This was referenced Feb 4, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
As title says. Adds boostrap5 overrides for Cassiopea as was done for Atum (#32166 )
This corrects Breadcrumbs as well as Rounded corners (#32177) and more in modals.
Testing Instructions
Install Persian language. Make it default language in frontend.
Switch to Persian in back-end and install the blog sample data.
Load frrontend
Check Breadcrumbs path
Check input groups rounded corners (in login form but also in the xtd modals)
Check the "X" close button in xtd modals.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Note
As in #32177 , I have not deleted the input group classes present in template-rtl.scss
The star icon, part of login form, may still need a tweak
.input-group-textshould have no border radius