-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Cassiopeia variables #32467
[4.0] Cassiopeia variables #32467
Conversation
This PR cleans up the scss variables being used in cassiopeia grid breakpoints - removed no reason to override grid containers - removed no reason to override
Testing instructions are "Check that the site looks as well as before"? |
Check that it compiles and check the typography page of the sample data |
Someone with better frontned skills than me needs to ensure that the changes from em back to the bootstrap grid and font sizes are the same. |
@drmenzelit Could you have a look on it? And eventually also close your PR #32446 in favour of this and possible future fixes for removing overrides of BS SCSS in Cassiopeia? Thanks in advance. I know it was not your idea to override all the BS stuff in Cassiopeia. |
The changes from Brian are fine, I don't see changes in the layout. But in my PR were 2 changes that we can need: |
@drmenzelit I've merged your PR and than have solved the conflict in _variables.scss here resulting from that merge. I hope the latter will help with @brianteeman not biting me. |
@richard67 in future I would prefer it if you didnt merge anything into my pr as it breaks my workflow |
@brianteeman Ok, noticed. Just thought it would help. |
I have tested this item ✅ successfully on 6770f52 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32467. |
I have tested this item ✅ successfully on 6770f52 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32467. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32467. |
Thanks! |
thanks |
This PR cleans up the scss variables being used in cassiopeia - the less we change the easier it is to maintain when upstream changes and we dont miss out on features such as rfs and xxl
z-index also needs to be reviewed but thats for another PR as is doing the same review for atum.
all the other cassiopeia overrides need to be checked as well to make sure they are not overriding things that it doesnt need to. This is just a start that I hope some people with more frontend skills can continue in another pr