Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s/404/500 #32579

Merged
merged 1 commit into from Mar 15, 2021
Merged

s/404/500 #32579

merged 1 commit into from Mar 15, 2021

Conversation

PhilETaylor
Copy link
Contributor

@PhilETaylor PhilETaylor commented Mar 3, 2021

This is triggered If the path to the images folder is not a directory.

The error raised is not a HTTP 404 Page Not Found, this is factually incorrect, there is no "page" that is not found.

Its an InvalidArgumentException therefore it should be a HTTP 500 Internal Server Error, the error is internal, its not a page not found. Its an Error like JERROR_AN_ERROR_HAS_OCCURRED states. a 404 is not an error.

Prior to Joomla 3.9.25 you would get a more helpful message:

Screenshot 2021-03-03 at 20 50 29

After 3.9.25 you get this which is less helpful:

Screenshot 2021-03-03 at 20 50 57

@toivo
Copy link
Contributor

toivo commented Mar 4, 2021

I have tested this item ✅ successfully on 70d36a7

Tested successfully in 3.9.26-dev of 4 March.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32579.

@ChristineWk
Copy link

ChristineWk commented Mar 5, 2021

@PhilETaylor
Pls don't don't laugh at me :-) tks.

Just for testing, I changed intentionally under media > options the path images to application. I know, that's wrong :-) Got Actual Result.
But: content > media is broken now. Which file should I load from a clean J 3.9.25? Under FTP, the images are there.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32579.

@ChristineWk
Copy link

Solved now via Backend.
System > Global Configuration > Site > Media > Path to File Folder & to Images Folder > images.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32579.

@chmst
Copy link
Contributor

chmst commented Mar 6, 2021

@ChristineWk so was your test successful? Then please mark it in the issue tracker.

@infograf768
Copy link
Member

infograf768 commented Mar 6, 2021

Shall not we use a similar code as in filesystem/folder.php error instead of a simple error has occured??

Text::sprintf('JLIB_FILESYSTEM_ERROR_PATH_IS_NOT_A_FOLDER_FOLDER', $path), Log::WARNING, 'jerror');

or is that a problem to display part of a path?

@infograf768
Copy link
Member

I have tested this item ✅ successfully on 70d36a7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32579.

@infograf768
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32579.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 6, 2021
@infograf768 infograf768 added this to the Joomla! 3.9.26 milestone Mar 6, 2021
@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 3.9.26 milestone Mar 6, 2021
@richard67 richard67 added this to the Joomla! 3.9.26 milestone Mar 6, 2021
@rdeutz rdeutz merged commit 7aff841 into joomla:staging Mar 15, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants