New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Apostrophe in alias #32924
[4.0] Apostrophe in alias #32924
Conversation
Add an additional filter to the alias generator to remove any apostrophe instead of replacing it with a dash. ### Example For example the alias for an article "Brian's Pull Request" ### before "brian-s-pull-request" ### after "brians-pull-request"
@brianteeman Wouldn't it be better just to add the apostrophe to the list of allowed characters in the existing I.e. change
to
instead of adding the new |
because its not an allowed character. it just needs to be removed - not replaced |
Ah, I forgot the removal, silly me. |
This comment was marked as abuse.
This comment was marked as abuse.
I have tested this item ✅ successfully on d83aacd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32924. |
I have tested this item ✅ successfully on d83aacd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32924. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32924. |
But it is valid only for english. IT FR Magento, Prestashop, Drupal, Typo3, and many other doesn't remove the dash for the apostrophe. Only Wordpress. Maybe should we let the language package drive this choiche? |
Then you have a definite article of just the character "l" which is also wrong as the alias would be "l-acqua" |
The question is what is more wrong to a native speaker of these languages. |
Evidently @simbus82 is totally right. We do have a solution though, @simbus82 , and it is to use unicode aliases. We could add in after line 162 the line This would give from the original title the alias |
Add an additional filter to the alias generator to remove any apostrophe instead of replacing it with a dash. This has annoyed me forever and I waste so much time doing this manually for every alias
Example
For example the alias for an article "Brian's Pull Request"
before
"brian-s-pull-request"
after
"brians-pull-request"
Note Includes unit test