-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] webp support in templates #33087
Conversation
joomla#31048 provided the library level support for webp images This PR adds webp to the list of allowed image types for com_templates. It does not have an update sql as that would change user data. This isnt really anything to test here accept codestyle as using webp images in templates was the test for the libray update so we know it works
I have tested this item ✅ successfully on 7f4cfaa This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33087. |
I have tested this item ✅ successfully on 7f4cfaa This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33087. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33087. |
I have tested this item 🔴 unsuccessfully on 7f4cfaa This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33087. |
To test the resize and cropping of a webp image. Upload an image and resize and/or crop. Then download the image and open in a text editor. If it is still a webp image you will see something like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing the actual process this time 🤦🏻♂️
The change only impacts the default. To actually test if all this works, I've had to go to System > Site Templates > Options and add wepb (and png) to the list.
I note that the default is missing PNG.
In testing, I also found an issue if the extension of the file is upper case. sample.PNG would upload, but then not be visible in the file tree. Adding GIF,JPG,JPEG,PNG,WEBP to the list of allowed extensions then allowed the uppercase extension to be viewed. Is it worth adding that now, or is this something to be raised as a separate issue to fix in the uploader so that it makes the extensions lowercase when the files are uploaded? |
Beyond the scope of this PR - please create a separate issue |
I have tested this item ✅ successfully on e64306b Resizing and Cropping a webp image saves the image as a webp image correctly. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33087. |
I have tested this item ✅ successfully on e64306b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33087. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33087. |
Thanks |
#31048 provided the library level support for webp images
This PR adds webp to the list of allowed image types for com_templates. It does not have an update sql as that would change user data.
This isnt really anything to test here accept codestyle as using webp images in templates was the test for the libray update so we know it works
adding support to the media manager will be in its own pr (its a bit more complex)