New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Xtd modals done right #33216
[4.0] Xtd modals done right #33216
Conversation
Appveyor failure is not related to this PR. |
I have tested this item ✅ successfully on e65da44 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33216. |
I have tested this item ✅ successfully on 55e6ca9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33216. |
I have tested this item ✅ successfully on 3c89ba0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33216. |
1 similar comment
I have tested this item ✅ successfully on 3c89ba0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33216. |
rtc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33216. |
@dgrammatiko Is the "Documentation Changes Required" still up to date, i.e. it needs documentation changes? Or has that become obsolete after your recent changes? I ask because if it needs documentation changes, I have to set the corresponding label before merging, so it later won't be forgotten. |
It should be B/C unless I got totally wrong. Let me explain: I introduce here a new property |
So does it need doc changes or not? That's still not clear to me. A simple "yes" or "no" is sufficient for me, any answer will not block RTC. |
Yes, If https://docs.joomla.org/Special:MyLanguage/Editors_form_field_type this is all the docs about the editor field someone should totally rewrite that and include also the xtd-buttons and the expected properties for the button. |
Thanks! |
Pull Request for Issue #33210 .
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
Broken
Expected result AFTER applying this Pull Request
Fixed
Documentation Changes Required
NO~~Actually, yes! The PR #19789 from 2018 introduced the property
realName
which basically is the untranslated string for the button and this is a B/C break and although buttons without it should still work the J4 implementation of the buttons should dictate for it for a11y and also to ensure proper functionality of the multiple instances of a browser. ~~Rework the code so it should be B/C although J4 XTD Buttons should have a property
name
and anothericon
to ensure there won't be accidental conflicts