-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Add toolbar.scss in Cassiopeia #33403
Conversation
I have tested this item ✅ successfully on 59b1cce This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33403. |
@Quy Code review please |
Sorry I am not at my computer to test. I will do tomorrow. |
No problem |
I have tested this item ✅ successfully on 59b1cce This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33403. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33403. |
Thank you for this PR @rjharishabh |
@bembelimen I want to change PX to REM |
Default is: 1rem == 16px |
If you use the same toolbar anyways, you can ofc import it directly instead having two versions... |
@bembelimen you can't import it because there are atum only variables |
Back to pending due to changes requested in comments above. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33403. |
Yes, there are atum specific variables like |
@bembelimen why are you asking for the rem to be converted to px? This file was identical to the one in atum except for the color variables. I'm wondering what the logic is for that request. The link you posted as an example just opens the entire file so its not clear if you really meant the entire file or just some specific parts. /me confused and can't see anything wrong with the original pr |
Sorry my fault, the link was only for the ".row" because that's a default element exactly for adding the margin. So it hurts a bit my guts to remove the margin that way, just wanted to point at it as example for "hard enforce". The px => rem thing was independent from it another issue. We should not mix it I think but have rem when not a 1px border. |
I understand you now. However as its just the same in atum I wouldnt bother to change it. the px/rem thing is beyond my skillset. Again its just a direct copy from atum and to be honest seeing a value of .313 is just as ugly |
Same with me Now I understand @bembelimen @brianteeman It's my mistake to understand it in a wrong way |
I have tested this item ✅ successfully on 59b1cce This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33403. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33403. |
Thanks! |
Thanks for merging |
This css was added in error with joomla#33403 It is not needed in the front end as this is used only for the mobile admin ui toggler seen below
This css was added in error with #33403 It is not needed in the front end as this is used only for the mobile admin ui toggler seen below
Pull Request for Issue #33392.
Summary of Changes
Replicate
Atum
toolbar inCassiopeia
Testing Instructions
http://localhost/joomla-cms/index.php/create-a-post/template-settings
Select
npm run build:css
Select
Actual result BEFORE applying this Pull Request
subhead noshadow
missingCSS
Expected result AFTER applying this Pull Request
Added
CSS
insubhead noshadow
Documentation Changes Required
None