Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Frontend: Removes Extra hr at the end of Module Edit View #33554

Merged
merged 1 commit into from
May 5, 2021

Conversation

YatharthVyas
Copy link
Contributor

@YatharthVyas YatharthVyas commented May 5, 2021

Pull Request for Issue #33547 .

Summary of Changes

Removes extra <hr> and adds margin to compensate for the gap

Testing Instructions

Prerequisites: Install Blog Sample Data

  1. Visit Frontend
  2. Login as Administrator
  3. Click on Edit for any module
  4. Scroll to the bottom of the form

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

None

@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on 8dbe4a5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33554.

1 similar comment
@ghost
Copy link

ghost commented May 5, 2021

I have tested this item ✅ successfully on 8dbe4a5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33554.

@alikon
Copy link
Contributor

alikon commented May 5, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33554.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 5, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone May 5, 2021
@chmst chmst merged commit 75ef0b1 into joomla:4.0-dev May 5, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 5, 2021
@chmst
Copy link
Contributor

chmst commented May 5, 2021

Thanks!

@YatharthVyas YatharthVyas deleted the frontend-hr-remove branch May 8, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants