[4.0] Underline links by default

[ciar4n]

Pull Request for Issue #33629 .

Summary of Changes

Underline links by default

Testing Instructions

Actual result BEFORE applying this Pull Request

By default links are not underlined

Expected result AFTER applying this Pull Request

By default links are underlined

Documentation Changes Required

[ciar4n]

I'm not a fan myself but I'm assuming this is a AA a11y requirement?

[ciar4n]

@PhilETaylor Agreed. Underline removed from icons with 2a68f4c

Im sure our resident expert will be along to confirm or deny this is an accessibility thing :)

@brianteeman Willing or not, I'm assigning that grand title to you 😉

[brianteeman]

it was the removal of the flex-grow that caused the problem i think

[ghost]

I have tested this item ✅ successfully on 2a68f4c

If there is time for finetuning:

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33808.}

[ceford]

I have tested this item ✅ successfully on 2a68f4c

Many years ago I read somewhere that links are supposed to be visually distinguishable from adjacent text. So this fits the bill although the underline is barely visible and I agree with others it is a bit yucky. Whatever happened to the default ancient blue/purple underlined scheme?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33808.}

[richard67]

If there is time for finetuning:

@ciar4n Do you think you could fix that, too, the underlined space between the link and any appended language badge?

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33808.}

[brianteeman]

Please remove RTC the issue reported by @sandramay0905 needs to be fixed

[richard67]

Back to pending. See previous comments.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33808.}

[brianteeman]

Is it possible to only show the underline on the text and not the whitespace between the icon and the text?

Probably something like adding display: contents; to the link as the problem comes from the whitespace (newlines and tabs)

[richard67]

Is this PR here still needed or useful now as #33811 has been merged?

[chmst]

Underline together with icon is really too much and not required. A user must see what is a link but the icon is sufficient for that.

[ciar4n]

Is this PR here still needed or useful now as #33811 has been merged?

If #33811 is the accepted solution then maybe this PR is overkill as it makes links underlined by default where #33811 only underlines links in the cpanel modules?

[ciar4n]

@sandramay0905 Could you detail for me how to replicate? ....

[ghost]

@ciar4n You need a multilanguage site, you can see it on Menu Dashboard for the menus having Home set.