Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3] Fixing search suggestions for mixed-case searches #33942

Merged
merged 2 commits into from Jun 10, 2021

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented May 18, 2021

Summary of Changes

The search suggestions are not lowercasing the search term when searching for suggestions, thus having no result when the search term starts with an uppercase character. This should fix this.

Testing Instructions

  1. Setup Smart Search
  2. Search for "Joomla" and see no suggestions
  3. Apply patch
  4. Type in "Joo" and see that you get suggestions with "joomla"

@richard67
Copy link
Member

For some reason this PR doesn't work for me on current staging, while the same fix for J4 with PR #33940 worked for me on 4.0-dev. I have no idea why. Will continue to check.

@ghost
Copy link

ghost commented May 19, 2021

I have tested this item 🔴 unsuccessfully on 7baba66

Typed in "Joo", no suggestions.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33942.

@Hackwar
Copy link
Member Author

Hackwar commented May 19, 2021

Please test again. This should work now...

@ghost
Copy link

ghost commented May 19, 2021

I have tested this item ✅ successfully on 6c5478d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33942.

1 similar comment
@richard67
Copy link
Member

I have tested this item ✅ successfully on 6c5478d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33942.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33942.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 19, 2021
@richard67 richard67 modified the milestone: Joomla! 3.9.28 May 19, 2021
@chmst chmst merged commit 280f931 into joomla:staging Jun 10, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 10, 2021
@chmst
Copy link
Contributor

chmst commented Jun 10, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants