-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Fix narrow column width in list view of media manager #33945
Conversation
I have tested this item ✅ successfully on cfb3f4e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33945. |
I have tested this item ✅ successfully on cfb3f4e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33945. |
@brianteeman
If you consider line break a bad solution I can replace it with min-width property. |
The size of the other columns is way too big. you really dont want to wrap a filename unless you absolutely have to Better to set some more sensible column widths such as
|
But we are still gonna have the problem when the file name is too big. Try to add symbols to a filename in devtools. |
Always going to happen but we can reduce the times when it will happen by setting sensible column widths in the beginning - especially when the width of the data in the column is never going to be that wide |
Please, test new patch. |
I have tested this item ✅ successfully on b1b17be This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33945. |
I have tested this item ✅ successfully on b1b17be This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33945. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33945. |
Back to pending, see comment #33945 (comment) . This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33945. |
Doing this in order to align the table columns with the "check all" button. Here we set 'width' and 'min-width' properties to the type column and remove the 'width' property from the name column. By doing this the type column will always have size of 50px (as the "check all" button) and the name column will take all free place.
The patch works on my machine. Please, test it too. |
I have tested this item ✅ successfully on 0d9143d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33945. |
What do you mean? Please, send screenshot. |
I'm not sure & see it now in this way: or what do you mean @ceford? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33945. |
#33945 (comment) |
I have tested this item ✅ successfully on 0d9143d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33945. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33945. |
In Firefox, it is a pixel off to the left. In Chrome, it is fine. The toggle checkbox is 50px. Please see if you can use the same value and look good in both browsers. |
In Chrome, it is a pixel off to the right, if set min-width equals to 50px. |
Merging as this is better than before. Thank you! |
Pull Request for Issue #33943.
Summary of Changes
Fix of the narrow column width in media manager.
Testing Instructions
Go to Content > Media
Click List icon.
Go to sampledata > parks > landscape
Actual result BEFORE applying this Pull Request
Icons column has small width
Expected result AFTER applying this Pull Request
Icons column has enough width