[4] remove method allow parent to run #34118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on f6effc7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34118. |
|
I have tested this item ✅ successfully on f6effc7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34118. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34118. |
|
@PhilETaylor After your other PR #34060 has been merged, this one had a conflict. I've allowed myself to solve it and think I did it right. But I'd feel safer if you could have a quick look on it. The diff on GitHub looks strange but I think that's just GitHub. |
bembelimen
pushed a commit
that referenced
this pull request
Nov 23, 2021
* [4.0] Notification icons (#34226) * remove method allow parent to run (#34118) Co-authored-by: Richard Fath <richard67@users.noreply.github.com> * [4.0] Changing title to tooltip for template preview (#33292) * [4.0] Changing title to tooltip fpr template preview * Update location path in description (#34238) * Fix patterns field check when field empty and not required (#34124) * [4.0] Finish transition from CSS classes "label-" to "alert-" for the pre-update check (#34227) * [4.0] mod_popular with disabled hits (#34257) * [4.0] mod_popular with disabled hits When hits are disabled for articles it makes no sense to display the Most Read Articles module in the site or admin as the contents will never be updated. This PR changes the output of the module so that instead of a list of non-updating articles a message is displayed. * [4.0] Use MVCFactory to create model (#34092) * Use MVCFactory to create models * CS * Fix row selecting, when module is disabled (#34273) * Media web service implementation. * Media web service implementation. * Fix hard coded adapter name default. * Fix missing url and tempUrl attributes in single item response. * Remove useless comments. * Replace 'PATH' with 'STRING' for cleaning of input parameters. * Adds required parameter checks and removes global exception handling. * Adds media web service specific language strings. * Adds exception handling. * Adds missing exception handler and fixes wrong path return value after move/rename. * Use exception message as error title. * Adds proper FileNotFound exception handling for GET requests. * Fixes handling of status code. * Fixes some types, formatting and similar stuff. * Fixes yet another sloppy typo. * restore file * Fix some docs * Adapter endpoint * Add plugin to install file * Add tests * Update api/components/com_media/src/Helper/MediaHelper.php Co-authored-by: Phil E. Taylor <phil@phil-taylor.com> * Update api/components/com_media/src/Helper/MediaHelper.php Co-authored-by: Phil E. Taylor <phil@phil-taylor.com> * Update api/components/com_media/src/Model/MediaModel.php Co-authored-by: Phil E. Taylor <phil@phil-taylor.com> * Update api/components/com_media/src/Model/MediumModel.php Co-authored-by: Phil E. Taylor <phil@phil-taylor.com> * Update api/components/com_media/src/View/Media/JsonapiView.php Co-authored-by: Phil E. Taylor <phil@phil-taylor.com> * Update libraries/src/Error/JsonApi/SaveExceptionHandler.php Co-authored-by: Phil E. Taylor <phil@phil-taylor.com> * Update api/components/com_media/src/Controller/MediaController.php Co-authored-by: Phil E. Taylor <phil@phil-taylor.com> * Update api/components/com_media/src/Controller/MediaController.php Co-authored-by: Phil E. Taylor <phil@phil-taylor.com> * Update api/components/com_media/src/Model/AdaptersModel.php Co-authored-by: Phil E. Taylor <phil@phil-taylor.com> * Update api/components/com_media/src/Model/MediaModel.php Co-authored-by: Phil E. Taylor <phil@phil-taylor.com> * docs * Update api/components/com_media/src/View/Media/JsonapiView.php Co-authored-by: Phil E. Taylor <phil@phil-taylor.com> * int * cs * cs * more cleanup * tabs * restore * Test all endpoints * Update api/components/com_media/src/Model/MediaModel.php Co-authored-by: Phil E. Taylor <phil@phil-taylor.com> * Hardening * Tests fix for drone * Update Api.php * Create directory in test with correct permissions * Add more tests and remove static helper * Update tests/Codeception/api/com_media/MediaCest.php Co-authored-by: Phil E. Taylor <phil@phil-taylor.com> * Update tests/Codeception/_support/Helper/Api.php Co-authored-by: Phil E. Taylor <phil@phil-taylor.com> * cs Co-authored-by: Brian Teeman <brian@teeman.net> Co-authored-by: Phil E. Taylor <phil@phil-taylor.com> Co-authored-by: Richard Fath <richard67@users.noreply.github.com> Co-authored-by: infograf768 <infografjms@gmail.com> Co-authored-by: Quy <quy@fluxbb.org> Co-authored-by: Ruud <info@onlinecommunityhub.nl> Co-authored-by: Tuan Pham Ngoc <github@joomdonation.com> Co-authored-by: Fedir Zinchuk <getthesite@gmail.com> Co-authored-by: Pieter-Jan de Vries <pieter@obix.nl>
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Oct 18, 2023
This code was removed in joomla#34060 and was accidentally brought back in joomla#34118 The code cannot be used anywhere as _buildQuery does not exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code review.
This code is not needed, the parent class
_getListcan be used instead.$oddis not actually used in the view either.//cc @joomdonation