Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Capitalize "Hide all messages" #34765

Merged
merged 2 commits into from Sep 8, 2021
Merged

Conversation

Quy
Copy link
Contributor

@Quy Quy commented Jul 12, 2021

Summary of Changes

For consistency, capitalize "Hide all messages" button in toolbar.

Testing Instructions

Click Post Installation Messages button.
See capitalization in button of toolbar.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Jul 12, 2021
@richard67
Copy link
Member

I have tested this item ✅ successfully on 1d7aba0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34765.

1 similar comment
@ChristineWk
Copy link

I have tested this item ✅ successfully on 1d7aba0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34765.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34765.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 12, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone Jul 12, 2021
@brianteeman
Copy link
Contributor

@richard67
Copy link
Member

So the “all” should be lowercase because of “Do not capitalise joining words and words of three characters or less such as and, to, for.”. Sure we fulfill that everywhere?

@richard67 richard67 removed the RTC This Pull Request is Ready To Commit label Jul 12, 2021
@joomla-cms-bot joomla-cms-bot removed this from the Joomla 4.0 milestone Jul 12, 2021
@richard67
Copy link
Member

Back to pending.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34765.

@richard67 richard67 added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Jul 12, 2021
@Quy
Copy link
Contributor Author

Quy commented Jul 12, 2021

I would say All has significance here vs. to, for, etc. So you are ok with this?

Hide all Messages

@Quy
Copy link
Contributor Author

Quy commented Jul 12, 2021

or change to Hide Messages?

@richard67
Copy link
Member

I'm not a native speaker and did not know our style guide in detail, so I hope @brianteeman can advise further.

@Quy
Copy link
Contributor Author

Quy commented Jul 12, 2021

Here are some strings with All.

COM_ASSOCIATIONS_PURGE="Delete All Associations"
COM_ACTIONLOGS_EXPORT_ALL_CSV="Export All as CSV"
COM_CATEGORIES_CATEGORIES_VIEW_DEFAULT_TITLE="List All Categories"

@richard67
Copy link
Member

I had the same in mind and so to me this PR seemed to be ok as it is, also according to capitalization rules of famous newspapers who capitalize “All” in their titles.

@richard67
Copy link
Member

But I don’t wanna argue with native speakers as I am not one.

@richard67 richard67 removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Jul 13, 2021
@richard67
Copy link
Member

richard67 commented Jul 13, 2021

Back to RTC due to @Quy 's findings above. See also e.g. https://capitalizemytitle.com/ , which suggest "Hide All Messages" in all available modes. They (and also other sources) say that pronouns are capitalized, and "All" is a kind of pronoun. I assume the Joomla style guide describes the rule in a (too much and so wrong?) simplified way and possibly needs to be corrected.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34765.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 13, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone Jul 13, 2021
@brianteeman
Copy link
Contributor

all those sources are for US english!! But do what you want. Styleguides seem optional in joomla and only relevant when the sun is in the vernal equinox

@richard67
Copy link
Member

richard67 commented Jul 13, 2021

all those sources are for US english!! But do what you want. Styleguides seem optional in joomla and only relevant when the sun is in the vernal equinox

@brianteeman So if the word "all" shall not be capitalized in titles or labels, why did you then make this PR? #34416 ... it seems you only care for style guides when it concerns PR's of other people but not yours.

@brianteeman
Copy link
Contributor

because it is different when there are only two words eg Check for Updates

@richard67
Copy link
Member

because it is different when there are only two words eg Check for Updates

@brianteeman Is that described somewhere in our style guide? I can't find anything about that here: https://developer.joomla.org/en-gb-user-interface-text-guidelines/capitalisation.html

@wilsonge
Copy link
Contributor

@brianteeman so what are you saying it should be? Hide all Messages I assume from the styleguide page? It looks a bit weird to me but if that's at least consistent it is what it is

@Quy
Copy link
Contributor Author

Quy commented Jul 13, 2021

delete-all-associations

export-all

@Quy Quy removed this from the Joomla 4.0 milestone Jul 14, 2021
@Quy Quy added this to the Joomla 4.0.1 milestone Jul 27, 2021
@richard67
Copy link
Member

@brianteeman Please respond to @wilsonge 's question above #34765 (comment) with respect to consistency with @Quy 's findings here #34765 (comment) .

@wilsonge wilsonge merged commit 616d643 into joomla:4.0-dev Sep 8, 2021
@wilsonge
Copy link
Contributor

wilsonge commented Sep 8, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants