New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Capitalize "Hide all messages" #34765
Conversation
I have tested this item ✅ successfully on 1d7aba0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34765. |
1 similar comment
I have tested this item ✅ successfully on 1d7aba0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34765. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34765. |
Please read the style guide and correct https://developer.joomla.org/en-gb-user-interface-text-guidelines/capitalisation.html |
So the “all” should be lowercase because of “Do not capitalise joining words and words of three characters or less such as and, to, for.”. Sure we fulfill that everywhere? |
Back to pending. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34765. |
I would say
|
or change to |
I'm not a native speaker and did not know our style guide in detail, so I hope @brianteeman can advise further. |
Here are some strings with COM_ASSOCIATIONS_PURGE="Delete All Associations" |
I had the same in mind and so to me this PR seemed to be ok as it is, also according to capitalization rules of famous newspapers who capitalize “All” in their titles. |
But I don’t wanna argue with native speakers as I am not one. |
Back to RTC due to @Quy 's findings above. See also e.g. https://capitalizemytitle.com/ , which suggest "Hide All Messages" in all available modes. They (and also other sources) say that pronouns are capitalized, and "All" is a kind of pronoun. I assume the Joomla style guide describes the rule in a (too much and so wrong?) simplified way and possibly needs to be corrected. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34765. |
all those sources are for US english!! But do what you want. Styleguides seem optional in joomla and only relevant when the sun is in the vernal equinox |
@brianteeman So if the word "all" shall not be capitalized in titles or labels, why did you then make this PR? #34416 ... it seems you only care for style guides when it concerns PR's of other people but not yours. |
because it is different when there are only two words eg Check for Updates |
@brianteeman Is that described somewhere in our style guide? I can't find anything about that here: https://developer.joomla.org/en-gb-user-interface-text-guidelines/capitalisation.html |
@brianteeman so what are you saying it should be? |
@brianteeman Please respond to @wilsonge 's question above #34765 (comment) with respect to consistency with @Quy 's findings here #34765 (comment) . |
Thanks! |
Summary of Changes
For consistency, capitalize "Hide all messages" button in toolbar.
Testing Instructions
Click Post Installation Messages button.
See capitalization in button of toolbar.