Simplify com_content params model state #34892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomdonation
changed the title
|
This pull request has automatically rebased to 4.2-dev. |
|
This pull requests has been automatically converted to the PSR-12 coding standard. |
rdeutz
changed the title
rdeutz
approved these changes
Oct 21, 2022
drmenzelit
approved these changes
Oct 21, 2022
|
Thx |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
The $params variable returned from $app->getParams(); already contains component parameters merged with active menu item parameters, so no need to merge it with active menu item parameters again.
For reference, we do it right in Categories model https://github.com/joomla/joomla-cms/blob/4.0-dev/components/com_content/src/Model/CategoriesModel.php#L69-L70
Testing Instructions
Code review only.