Simplify params model state for com_contact, com_newsfeeds

[joomdonation]

Pull Request for Issue # .

Summary of Changes

Use $app->getParams() to get $params variable. Less code, consistent with other model classes.

Testing Instructions

Code review should be enough.

[wilsonge]

https://github.com/joomla/joomla-cms/blob/staging/components/com_content/models/category.php#L117-L127 We have the same code in com_content at the moment.

Newsfeeds doesn't even merge the menu specific items :) https://github.com/joomla/joomla-cms/blob/staging/components/com_newsfeeds/models/category.php#L197

Overall I think this is right - we just need to get everything consistent at once.

[joomdonation]

@wilsonge We handle it different in com_content, thus I made a separate PR #34892 for com_content.

For newsfeeds, yes, we have it in different way, too. So 3 components, should work in the same way but we handle it different in each component :D. I will add the same change to com_newsfeeds into this PR

[joomdonation]

OK. I use similar code for com_newsfeeds. Assume it is accepted, we will have consistent code for the three components :).

[HLeithner]

This pull request has automatically rebased to 4.2-dev.

[joomla-bot]

This pull requests has been automatically converted to the PSR-12 coding standard.

[bembelimen]

Thx