-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Updating or uninstalling one library no longer removes another when both belong to same vendor. #34954
Conversation
…emoves another when both belong to same vendor. ### Summary of Changes Check if there are any other children before removing vendor folder. ### Testing instructions As described in joomla#34910
@BrainforgeUK Could you please give two sample libraries so that we can use it for testing? |
lib_bftest1.zip With J4 RC5 With Change In admin Extensions Manage page unininstall lib_bftest3 OK, folders for test1 and test2 still exist. |
I have tested this item ✅ successfully on 6b2c94b PHP version : 7.4 Thank you!! This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34954. |
Tested with Devilbox and library packages provided. PHP 7.4.20 Thank very much! This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34954. |
I have tested this item ✅ successfully on 6b2c94b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34954. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34954. |
happy to see yet another one Devilbox https://github.com/cytopia/devilbox/ user |
@BrainforgeUK Could you implement @joomdonation ' suggestion above - see #34954 (comment) - and remove the empty arrays for the last 2 parameters so the defaults are used? I will then help to get testers again. Thanks in advance. |
back to pending This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34954. |
…() so the defaults are used As suggestion made in pull comment.
Removed the empty arrays, as requested, |
Thanks |
@maikol-ortigueira @pabloarias Could you test again? There has been made a change. Thanks in advance. |
@BrainforgeUK Sorry I have to bother you again. My mistake, I promose it's the last time. Could you also remove the optional two boolean parameters which now are the last two, so only @joomdonation is right, we don't need to use absolute path here, so the last 2 could be "false, false" and so equal to the defaults instead of "false, true". |
@BrainforgeUK Thanks a lot, very appreciated. Will prepare to test now. |
Also removed the filter parameter as the default is the same. |
I have tested this item ✅ successfully on 19ba82c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34954. |
1 similar comment
I have tested this item ✅ successfully on 19ba82c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34954. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34954. |
@wilsonge Because it's a fix for the installer, I'd like to have that in 4.0, so I've set the 4.0 milestone. Feel free to change if not ok. |
Thanks! |
Pull Request for Issue # .
#34910
Summary of Changes
Check if there are any other children before removing vendor folder.
Testing Instructions
As described in #34910
Actual result BEFORE applying this Pull Request
Updating or uninstalling one library removes another when both belong to same vendor.
Expected result AFTER applying this Pull Request
Updating or uninstalling one library no longer removes another when both belong to same vendor.
Documentation Changes Required
Check if using library names like these is documented.
mycompany/mylibrary1
mycompany/mylibrary2