-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Let build tools always start clean #35048
[4.0] Let build tools always start clean #35048
Conversation
Considering your previous comment is it safe to remove all of |
Yeah, probably I should target only the vendor folders that Joomla delivers. That said the existing code already discards the vendor folder, so I guess I need to fine-tune that part |
@@ -788,6 +788,67 @@ | |||
"linkText": "Help me resolve this", | |||
"destFile": "/templates/system/fatal-error.html" | |||
} | |||
} | |||
}, | |||
"cleanUpFolders": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will someone remember to maintain this hardcoded list if some new extension which has assets will be added or removed in future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is the backbone of the build tools but you're right there are way too many hardcoded things here. Will refactor it so it's easier for maintenance
I have tested this item ✅ successfully on a964dec This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35048. |
I have tested this item ✅ successfully on a964dec This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35048. |
@richard67 My browser had some hick ups. Sorry for the confusion. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35048. |
I have not tested this item. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35048. |
@dgrammatiko how can I verify that the patch works? Should there be a difference between the backed up folder and the newly generated? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35048. |
There should be identical (assuming that the backup didn't had |
This PR is not needed urgently so I will switch it to draft and we can check it back after the GA |
@RickR2H @richard67 I've opened a new PR with the code from this one plus a replacement of a node package for the watch functionality. Please test #35198 |
Pull Request for Issue # .
Summary of Changes
npm install
is calledTesting Instructions
Before applying the patch make a backup of your current media folder
Apply the patch
Run
npm install
Compare the backup folder with the current media
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
@wilsonge this can wait till 4.0 is released