Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Do not minify tinymce languages #35878

Closed
wants to merge 1 commit into from

Conversation

brianteeman
Copy link
Contributor

Because of the way that tinymce works it can only use a language file that is named exactly the same as the language. As a result none of the minified files eg de.min.js will ever be used.

They are also listed as a language in the plugin configuration which is obviously also not correct.

this PR stops the minification of these languages files.

To test you should

  1. delete the contents of media\vendor\tinymce\langs
  2. run npm run build:js
  3. confirm that there are now no *.min.js in the media\vendor\tinymce\langs folder

Pull Request for Issue #35646

Because of the way that tinymce works it can only use a language file that is named exactly the same as the language. As a result none of the minified files eg de.min.js will ever be used.

They are also listed as a language in the plugin configuration which is obviously also not correct.

this PR stops the minification of these languages files.

To test you  should
1. delete the contents of `media\vendor\tinymce\langs`
2. run `npm run build:js`
3. confirm that there are now no *.min.js in the `media\vendor\tinymce\langs` folder
@ricardo1709
Copy link
Contributor

I have tested this item ✅ successfully on 1c09c93


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35878.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 1c09c93

I've verified that the minified version is never loaded and that the PR fixes the issue that you get "minified languages" in the language selection of the editor plugin settings when switching off automatic language detection so you get the language selection.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35878.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35878.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 23, 2021
@RickR2H
Copy link
Member

RickR2H commented Oct 23, 2021

I have tested this item ✅ successfully on 1c09c93


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35878.

@dgrammatiko
Copy link
Contributor

There's a better way according to their docs: https://www.tiny.cloud/docs/configure/integration-and-setup/#suffix

@dgrammatiko
Copy link
Contributor

@brianteeman can you try removing this line:

@brianteeman
Copy link
Contributor Author

That wouldnt stop the build scripts from creating the minified files

@brianteeman
Copy link
Contributor Author

There's a better way according to their docs: https://www.tiny.cloud/docs/configure/integration-and-setup/#suffix

Thats for the theme and plugins.

This PR is for the language files

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 23, 2021
@brianteeman
Copy link
Contributor Author

that's the last time I touch javascript

@brianteeman brianteeman deleted the tinymce_minify branch October 23, 2021 18:43
@richard67
Copy link
Member

Why closed? The PR is right, or do I miss something?

@richard67
Copy link
Member

Ah I see now, alternative PR #35883 .

@brianteeman
Copy link
Contributor Author

Create an issue. its ignored.
create a pr. suddenly people notice

@richard67
Copy link
Member

Well, maybe we just have too many issues so we have lost the overview :-(

@dgrammatiko
Copy link
Contributor

@brianteeman I just tried to help. I'm closing my PR so please reopen this one.

@richard67
Copy link
Member

And now?

@richard67
Copy link
Member

@dgrammatiko I don't think that @brianteeman wanted you to close your PR. Please re-open it.

@dgrammatiko
Copy link
Contributor

@richard67 I reopened the other PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants