-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Do not minify tinymce languages #35878
Conversation
Because of the way that tinymce works it can only use a language file that is named exactly the same as the language. As a result none of the minified files eg de.min.js will ever be used. They are also listed as a language in the plugin configuration which is obviously also not correct. this PR stops the minification of these languages files. To test you should 1. delete the contents of `media\vendor\tinymce\langs` 2. run `npm run build:js` 3. confirm that there are now no *.min.js in the `media\vendor\tinymce\langs` folder
I have tested this item ✅ successfully on 1c09c93 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35878. |
I have tested this item ✅ successfully on 1c09c93 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35878. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35878. |
I have tested this item ✅ successfully on 1c09c93 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35878. |
There's a better way according to their docs: https://www.tiny.cloud/docs/configure/integration-and-setup/#suffix |
@brianteeman can you try removing this line:
|
That wouldnt stop the build scripts from creating the minified files |
Thats for the theme and plugins. This PR is for the language files |
that's the last time I touch javascript |
Why closed? The PR is right, or do I miss something? |
Ah I see now, alternative PR #35883 . |
Create an issue. its ignored. |
Well, maybe we just have too many issues so we have lost the overview :-( |
@brianteeman I just tried to help. I'm closing my PR so please reopen this one. |
And now? |
@dgrammatiko I don't think that @brianteeman wanted you to close your PR. Please re-open it. |
@richard67 I reopened the other PR |
Because of the way that tinymce works it can only use a language file that is named exactly the same as the language. As a result none of the minified files eg de.min.js will ever be used.
They are also listed as a language in the plugin configuration which is obviously also not correct.
this PR stops the minification of these languages files.
To test you should
media\vendor\tinymce\langs
npm run build:js
media\vendor\tinymce\langs
folderPull Request for Issue #35646