New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Add information to the error message #35910
Conversation
Co-authored-by: Brian Teeman <brian@teeman.net>
Thanks! |
Got this message. See second sentence: This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35910. |
I have tested this item ✅ successfully on f1cf9ba This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35910. |
I have tested this item ✅ successfully on f1cf9ba This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35910. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35910. |
I have tested this item ✅ successfully on f1cf9ba This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35910. |
I think the communication is good thing in general, but I think this is only a band aid for the deeper problem (and does not fix it at all), which means, if the plugin is changed and e.g. there is a new order of steps or forever reasons the user cleans up the content from step 1, the installation will fail again with another error message. |
I agree. If it can only be installed once then it should be removed automatically once it has run |
I have tested this item ✅ successfully on f1cf9ba This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35910. |
The key thing is you can do only do once on a per-language basis (see #23633 (comment)). I'm merging this for now and if we can find a better solution we can always revert this. |
Thanks! |
joomla/joomla-cms#36072 joomla/joomla-cms#36066 joomla/joomla-cms#35960 joomla/joomla-cms#35729 joomla/joomla-cms#35910 joomla/joomla-cms#36172 (только en-GB) joomla/joomla-cms#35107 (из Joomla 3) joomla/joomla-cms#35841 (из Joomla 3)
Summary of Changes
Blog Sample Data can be installed only once. When the user repeats the installation, the installation fails with a message.
For new users this message is somehow cryptic. We can add a clearer information.
Testing Instructions
Install the Blog Sample Data once, then install again and see the error message.
Actual result BEFORE applying this Pull Request
Step 1 Failed with message: Another Tag has the same alias (remember it may be a trashed item).
Expected result AFTER applying this Pull Request
Documentation Changes Required