Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Add information to the error message #35910

Merged
merged 3 commits into from Nov 28, 2021

Conversation

chmst
Copy link
Contributor

@chmst chmst commented Oct 26, 2021

Summary of Changes

Blog Sample Data can be installed only once. When the user repeats the installation, the installation fails with a message.
For new users this message is somehow cryptic. We can add a clearer information.

Testing Instructions

Install the Blog Sample Data once, then install again and see the error message.

Actual result BEFORE applying this Pull Request

Step 1 Failed with message: Another Tag has the same alias (remember it may be a trashed item).

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Oct 26, 2021
Co-authored-by: Brian Teeman <brian@teeman.net>
@chmst
Copy link
Contributor Author

chmst commented Oct 26, 2021

Thanks!

@ChristineWk
Copy link

Got this message. See second sentence:

screen shot 2021-10-26 at 20 41 33


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35910.

@ChristineWk
Copy link

I have tested this item ✅ successfully on f1cf9ba

OK, I saw the change now on Github View.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35910.

@rjharishabh
Copy link
Contributor

I have tested this item ✅ successfully on f1cf9ba


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35910.

@rjharishabh
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35910.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 27, 2021
@khu5h1
Copy link
Contributor

khu5h1 commented Oct 28, 2021

I have tested this item ✅ successfully on f1cf9ba


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35910.

@bembelimen
Copy link
Contributor

I think the communication is good thing in general, but I think this is only a band aid for the deeper problem (and does not fix it at all), which means, if the plugin is changed and e.g. there is a new order of steps or forever reasons the user cleans up the content from step 1, the installation will fail again with another error message.
So I think this should be considerated, too.

@brianteeman
Copy link
Contributor

I agree. If it can only be installed once then it should be removed automatically once it has run

@chmst
Copy link
Contributor Author

chmst commented Nov 19, 2021

I know that #22634, #20479
It was an attempt to make it a little bit clearer as long as we have not good solution

@pritam825
Copy link
Contributor

I have tested this item ✅ successfully on f1cf9ba


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35910.

@wilsonge
Copy link
Contributor

The key thing is you can do only do once on a per-language basis (see #23633 (comment)). I'm merging this for now and if we can find a better solution we can always revert this.

@wilsonge wilsonge merged commit 5834a48 into joomla:4.0-dev Nov 28, 2021
@wilsonge
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants