Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix RTL for Sample Data Module #36784

Merged
merged 3 commits into from
Jan 22, 2022
Merged

Conversation

pritam825
Copy link
Contributor

@pritam825 pritam825 commented Jan 22, 2022

Pull Request for Issue #35850 (partly).

Testing Instructions

first choose the arabic language then
go to home dashboard -> Sample Data

Actual result BEFORE applying this Pull Request

Screenshot (1919)

Expected result AFTER applying this Pull Request

Screenshot (1920)

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 646ba4c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36784.

@brianteeman
Copy link
Contributor

Could you change the title of this PR to the name of the module please


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36784.

@Shubhamverma2796
Copy link
Contributor

I have tested this item ✅ successfully on 646ba4c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36784.

@richard67 richard67 changed the title bootstrap utilities [4.0] Fix RTL for Sample Data Module Jan 22, 2022
@richard67
Copy link
Member

@pritam825 I've allowed myself to adjust the title of your pull request as recommended by @brianteeman in his comment above.

Please always chose meaningful and understandable titles for pull requests. Thanks in advance.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36784.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 22, 2022
@pritam825
Copy link
Contributor Author

@brianteeman sir, @richard67 sir updated the title.
@richard67 sir, Thanks for updating, Sorry sir for the wrong title, actually I was confused with the title, now understood, Thanks a lot for helping me @brianteeman sir and @richard67 sir.

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
@pritam825
Copy link
Contributor Author

@richard67 , can you please have a look on this #36767 PR also, it would be great help, Thanks

@richard67
Copy link
Member

I've restored the previous human test results since the changes after that were just removal of a redundant space. So still RTC (ready to commit).

@pritam825
Copy link
Contributor Author

I've restored the previous human test results since the changes after that were just removal of a redundant space. So still RTC (ready to commit).

@richard67 thanks, I have opened an another PR also, which haven't confirmed yet that, it's right or wrong, can you please please confirm this PR #36767 also, Thanks in advance :)

@richard67
Copy link
Member

@richard67 , can you please have a look on this #36767 PR also, it would be great help, Thanks

@richard67 thanks, I have opened an another PR also, which haven't confirmed yet that, it's right or wrong, can you please please confirm this PR #36767 also, Thanks in advance :)

It does not need me to tell that 2 times.

And I am able to decide myself which PRs I am looking on.

@pritam825
Copy link
Contributor Author

Ok sir, Thanks :)

@bembelimen bembelimen merged commit 0c1e1c2 into joomla:4.0-dev Jan 22, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 22, 2022
@bembelimen
Copy link
Contributor

Thx

@bembelimen bembelimen added this to the Joomla 4.1.0 milestone Jan 22, 2022
@pritam825
Copy link
Contributor Author

Thanks for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants