-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Fix RTL for Sample Data Module #36784
Conversation
I have tested this item ✅ successfully on 646ba4c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36784. |
Could you change the title of this PR to the name of the module please This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36784. |
I have tested this item ✅ successfully on 646ba4c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36784. |
@pritam825 I've allowed myself to adjust the title of your pull request as recommended by @brianteeman in his comment above. Please always chose meaningful and understandable titles for pull requests. Thanks in advance. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36784. |
@brianteeman sir, @richard67 sir updated the title. |
Co-authored-by: Quy <quy@fluxbb.org>
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
@richard67 , can you please have a look on this #36767 PR also, it would be great help, Thanks |
I've restored the previous human test results since the changes after that were just removal of a redundant space. So still RTC (ready to commit). |
@richard67 thanks, I have opened an another PR also, which haven't confirmed yet that, it's right or wrong, can you please please confirm this PR #36767 also, Thanks in advance :) |
It does not need me to tell that 2 times. And I am able to decide myself which PRs I am looking on. |
Ok sir, Thanks :) |
Thx |
Thanks for merging |
Pull Request for Issue #35850 (partly).
Testing Instructions
first choose the arabic language then
go to home dashboard -> Sample Data
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request