Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] [UX] Reset hidden postinstallation messages #37423

Closed
wants to merge 12 commits into from

Conversation

magnussinger
Copy link
Contributor

Pull Request for Issue #37399

Summary of Changes

In the post-installation messages, you can now reset hidden messages before you have to hide all the other messages

Testing Instructions

There's an extra button in the toolbar, hide one message and press the reset button, and the message will be visible again

Actual result BEFORE applying this Pull Request

You had to hide all messages before making them visible again

Expected result AFTER applying this Pull Request

You can show hidden messages again before hiding all others before

Documentation Changes Required

None

@brianteeman
Copy link
Contributor

The reset button should not be displayed (or it should be disabled) if there are no hidden messages.

(I'm not convinced this button is a suitable solution to the issue. As I write in the issue there are several ways to achieve the aim. It all depends on what is the motivation/reason for the change.

@chmst
Copy link
Contributor

chmst commented Mar 30, 2022

Thank you for your contribution, @magnussinger!

This indeed solves the acute problem, that a hidden message cannot be reactivated. As you can see in the issue comments, this could be only an interim solution.

@magnussinger
Copy link
Contributor Author

Yes I'll fix that it only shows the button when messages are hidden later, but I think the solution with the button on top is a bit cleaner than minimizing hidden messages, but I'm open for suggestions

@magnussinger
Copy link
Contributor Author

@brianteeman I just updated my PR and it shows the button only when there are hidden messages now

@Quy
Copy link
Contributor

Quy commented Apr 11, 2022

Please fix and use the refresh icon instead of plus icon.

security-token

@magnussinger
Copy link
Contributor Author

@Quy I updated the button

@Quy
Copy link
Contributor

Quy commented Apr 12, 2022

Please also fix the security token warning. Thanks.

@magnussinger
Copy link
Contributor Author

@Quy I'm sorry but how can I see warnings in the backend? I somehow can't see the warning message

@Quy
Copy link
Contributor

Quy commented Apr 12, 2022

Click the Reset button in the toolbar.

@magnussinger
Copy link
Contributor Author

When I click on the reset button, there is no warning message, I just re-tried it

@Quy
Copy link
Contributor

Quy commented Apr 12, 2022

Let me try again with the prebuilt package and report back later.

@magnussinger
Copy link
Contributor Author

Thanks

@richard67 richard67 added the PBF Pizza, Bugs and Fun label Apr 22, 2022
@Quy
Copy link
Contributor

Quy commented Jun 15, 2022

Closing in favor of #38064. Thank you.

@Quy Quy closed this Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PBF Pizza, Bugs and Fun
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants