Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

37313 #37537

Closed
wants to merge 2 commits into from
Closed

37313 #37537

wants to merge 2 commits into from

Conversation

Rpaudel379
Copy link

@Rpaudel379 Rpaudel379 commented Apr 11, 2022

Pull Request for Issue # 37313

Summary of Changes

Added a line of code to "administrator\components\com_scheduler\forms\task.xml" on line numbers 199, 208, 217, 226, 235
so that all the values in area Crone Match should be selected.

Testing Instructions

Create Demo Task - Sleep
Select Cron Expression Advanced as Execution Rule
Do not select all values in area Crone match.

then try to save & close.

Actual result BEFORE applying this Pull Request

Screenshot (46)

Expected result AFTER applying this Pull Request

scrnli_4_12_2022_12-41-01 AM
scrnli_4_12_2022_12-44-42 AM

Documentation Changes Required

no changes required

@richard67
Copy link
Member

@Rpaudel379 My comment from another, closed PR for the same issue also applies here, see #37350 (comment) .

Also the testing instructions should include a test that nothingness broken for other kinds of execution rules that the advanced cron expression .

Finally you should give your pull request a meaningful title.

@richard67
Copy link
Member

P.S.: There is another pull request from another author for the same issue, and that other pull request is older, so your will very likely be closed as duplicate.

@brianteeman
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on a2fb719

Now you can not savee anything other than a cron


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37537.

@Quy
Copy link
Contributor

Quy commented Apr 14, 2022

Closing as this is not the correct fix. Thank you for trying.

@Quy Quy closed this Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants