[4.2] Move check for discoverable extensions to model #37605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quy
reviewed
Apr 22, 2022
brianteeman
reviewed
Apr 22, 2022
administrator/components/com_installer/src/Model/DiscoverModel.php
Outdated
Show resolved
Hide resolved
brianteeman
reviewed
Apr 22, 2022
administrator/components/com_installer/src/Model/DiscoverModel.php
Outdated
Show resolved
Hide resolved
|
I have tested this item ✅ successfully on 469dbf7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37605. |
….php Co-authored-by: Brian Teeman <brian@teeman.net>
….php Co-authored-by: Brian Teeman <brian@teeman.net>
|
I have tested this item ✅ successfully on a9af3c7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37605. |
|
I have tested this item ✅ successfully on a9af3c7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37605. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37605. |
|
Thanks everybody |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Ongoing effort to inject the database into components and get rid of the deprecated Factory::getDbo(); calls. This pr moves a database function in the discover view to the model where the database is available.
Testing Instructions
Go to the site /administrator/index.php?option=com_installer&view=discover.
Actual result BEFORE applying this Pull Request
All works.
Expected result AFTER applying this Pull Request
All works.