Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Move the logic to get the menu item language on login to the model #37614

Merged
merged 12 commits into from Jun 18, 2022

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Apr 22, 2022

Summary of Changes

The logic to get the language for the return menu item should be in the model as there is the database available.

Testing Instructions

  • Create an articles list menu item
  • Create a login menu item with a redirect to the articles list menu item
    image
  • In the file /libraries/src/Language/Multilanguage.php replace line 44 with {return true;
  • On the front end log in with this new menu item

Actual result BEFORE applying this Pull Request

You should get redirected to the articles list menu item.

Expected result AFTER applying this Pull Request

You should get redirected to the articles list menu item.

@richard67 richard67 added the PBF Pizza, Bugs and Fun label Apr 22, 2022
@SumCompanyInc
Copy link

I have tested this item ✅ successfully on bf8dd2c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37614.

@roland-d roland-d merged commit b1385da into joomla:4.2-dev Jun 18, 2022
@roland-d roland-d deleted the j4/users/login-model branch June 18, 2022 18:08
@roland-d
Copy link
Contributor

Thanks everybody

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PBF Pizza, Bugs and Fun
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants