[4.1] Update deleted files list in script.php for upcoming 4.1.3 release and add missing form validation rule from 3.10 #37714
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This pull request (PR) updates the lists of files and folders to be deleted on update by script.php for the upcoming 4.1.3 release - details see below - and adds file "libraries/src/Form/Rule/CssIdentifierSubstringRule.php" from the 3.10-dev branch.
The "CssIdentifierSubstringRule.php" file has been added due to a security patch with commit 44b7b89 .
In Joomla 4.x this file is not really needed because the same security fix uses the "CssIdentifierRule" from this file https://github.com/joomla/joomla-cms/blob/4.1-dev/libraries/src/Form/Rule/CssIdentifierRule.php , which is more strict.
But it makes sense to keep that file, and so I add it with this PR. It can be used by 3rd party developers to validate form fields for parts of CSS identifiers like we had them in past (J3) in the core with the "CSS class suffix" fields, while the "CssIdentifierRule" only make sense for validating complete CSS identifiers.
In detail following changes are made on the lists of files and folders to be deleted on update by script.php:
There have not been detected any files or folders to be added to the lists in script.php by my tool.
Testing Instructions
Code review should be enough.
Actual result BEFORE applying this Pull Request
File "libraries/src/Form/Rule/CssIdentifierSubstringRule.php" doesn't exist.
In file "administrator/components/com_admin/script.php":
Expected result AFTER applying this Pull Request
File "libraries/src/Form/Rule/CssIdentifierSubstringRule.php" exists. It is equal to https://github.com/joomla/joomla-cms/blob/3.10-dev/libraries/src/Form/Rule/CssIdentifierSubstringRule.php except of the changed copyright format at the top and the leading backslash of the "defined" statement.
In file "administrator/components/com_admin/script.php":
Documentation Changes Required
None.