New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.4] JTable::store(true) to update NULLs fails if assets are tracked #37993
[4.4] JTable::store(true) to update NULLs fails if assets are tracked #37993
Conversation
Hmm, but when doing a real test as suggested to emulate the real case, I do not get any error without this PR applied. |
@Denitz As I wrote in my previous comments, I think by review that your PR is right. But I can't really reproduce the issue on a current 4.1-dev. I do not get any kind of error without the PR applied and doing the suggested edit of the "libraries/src/Table/Content.php" file. Could you check and report back how you did get an error and which kind of error? |
Sorry, can't reproduce as well, too much time has passed :( |
Can replicate following this instruction, but get another message.
BUT .. I could replicate it only once and never again. |
This pull requests has automatically rebased to 4.2-dev. |
This pull requests has been automatically converted to the PSR-12 coding standard. |
…ails_if_assets_are_tracked
@richard67 Please rebase to 4.3-dev, I don't want to loose your approval after my rebase. |
Anybody, please delete this PR if I won't remind about it in 5 years, otherwise it means that I've gone to better place. |
…ails_if_assets_are_tracked
…ails_if_assets_are_tracked
This pull request has been automatically rebased to 4.4-dev. |
I have tested this item ✅ successfully on 54ac9e4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37993. |
What did you do to succesfully get the error message? I am not getting any errors before applying the patch. |
I have tested this item 🔴 unsuccessfully on 54ac9e4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37993. |
@TLWebdesign The testing instructions say that it needs to implement a custom table class to reproduce the issue. That means some programming or some 3rd party extension which does that. Have you done that? If no, then change your test result to "not tested". Thanks in advance. |
it also said you could do this approach: Or just edit libraries/src/Table/Content.php, replace at the bottom return parent::store($updateNulls); with return parent::store(true); to emulate the real case, next try to save an article. Thats what i tried. |
I see. Was reading not far enough. |
I have tested this item ✅ successfully on 54ac9e4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37993. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37993. |
…ails_if_assets_are_tracked
Thank you! |
Pull Request for Issue #30995.
Summary of Changes
Store assets without NULLs.
Testing Instructions
Create custom table class with assets (property
$asset_id
is required) and try to executeparent::store(true)
.Or just edit
libraries/src/Table/Content.php
, replace at the bottomreturn parent::store($updateNulls);
withreturn parent::store(true);
to emulate the real case, next try to save an article.Actual result BEFORE applying this Pull Request
See error.
Expected result AFTER applying this Pull Request
Save without errors.
Documentation Changes Required
No.