Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] pre-update check missing class #38074

Merged
merged 2 commits into from Jun 16, 2022
Merged

Conversation

brianteeman
Copy link
Contributor

The checkbox is not displayed correctly

<input type="checkbox" class=" me-3" id="noncoreplugins" name="noncoreplugins" value="1" required />

Should be changed to

<input type="checkbox" class="form-check-input me-3" id="noncoreplugins" name="noncoreplugins" value="1" required />

before

image

after

image

@brianteeman
Copy link
Contributor Author

could someone restart drone please

@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on 03b60f1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38074.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Jun 16, 2022

I have tested this item ✅ successfully on 03b60f1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38074.

@Quy
Copy link
Contributor

Quy commented Jun 16, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38074.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 16, 2022
@richard67
Copy link
Member

I could post a 3rd good tests since I've just tested with success (before I've noticed it is already RTC) 😄 For testing I have created a fake update site for a 4.3-dev release so the pre-update checker is shown.

@richard67 richard67 merged commit 97b600e into joomla:4.2-dev Jun 16, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 16, 2022
@richard67
Copy link
Member

Thanks all.

@richard67 richard67 added this to the Joomla 4.2.0 milestone Jun 16, 2022
@brianteeman brianteeman deleted the pre_update branch June 16, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants