Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] tag selection in article category menus #38088

Merged
merged 2 commits into from Jun 20, 2022

Conversation

brianteeman
Copy link
Contributor

Related Pull Request for Issue #38087 .

Summary of Changes

When creating a menu item of type article-category or article-list you can filter by tags.
This PR Prevents the ability to create new tags when selecting tags. They're not actually created anyway and it doesnt make sense that you would be able to create a new tag here anyway.

This PR uses a field attribute custom="deny" to prevent the fake ability to create a new tag.

Testing Instructions

Create a few articles with tags
Create an arrticle categoru blog and categpory list menu and select existing tags AND try to type in a non-existing tag and hit enter

Before

image

After

image

@ghost
Copy link

ghost commented Jun 18, 2022

I have tested this item ✅ successfully on 72b8d08

Test on menu item type Category Blog and Category List.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38088.

@ChristineWk
Copy link

I have tested this item ✅ successfully on 72b8d08


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38088.

@alikon
Copy link
Contributor

alikon commented Jun 20, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38088.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 20, 2022
@roland-d roland-d merged commit 4dd36fe into joomla:4.2-dev Jun 20, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 20, 2022
@roland-d
Copy link
Contributor

Thanks everybody

@roland-d roland-d added this to the Joomla 4.2.0 milestone Jun 20, 2022
@brianteeman brianteeman deleted the tag_menu_deny branch June 20, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants